Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2887353004: WIP mojo typemaps for WTF time types (Closed)

Created:
3 years, 7 months ago by Marijn Kruisselbrink
Modified:
3 years, 6 months ago
Reviewers:
dcheng
CC:
Aaron Boodman, abarth-chromium, blink-reviews, chromium-reviews, darin (slow to review), feature-vr-reviews_chromium.org, kinuko+watch, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP mojo typemaps for WTF time types BUG=

Patch Set 1 #

Messages

Total messages: 5 (1 generated)
Marijn Kruisselbrink
This is my current (obviously terrible) attempt at making it possible to pass Time and/or ...
3 years, 7 months ago (2017-05-18 18:55:36 UTC) #2
haraken
On 2017/05/18 18:55:36, Marijn Kruisselbrink wrote: > This is my current (obviously terrible) attempt at ...
3 years, 7 months ago (2017-05-19 01:57:21 UTC) #3
dcheng
On 2017/05/19 01:57:21, haraken wrote: > On 2017/05/18 18:55:36, Marijn Kruisselbrink wrote: > > This ...
3 years, 7 months ago (2017-05-19 02:12:28 UTC) #4
haraken
3 years, 7 months ago (2017-05-23 11:17:31 UTC) #5
On 2017/05/19 02:12:28, dcheng wrote:
> On 2017/05/19 01:57:21, haraken wrote:
> > On 2017/05/18 18:55:36, Marijn Kruisselbrink wrote:
> > > This is my current (obviously terrible) attempt at making it possible to
> pass
> > > Time and/or TimeTicks over mojo into blink... Not sure what a cleaner way
of
> > > doing this would be though, as the combination of Time/TimeTicks being
> defines
> > > as [Native], and no conversions being allowed between base::Time and
> WTF::Time
> > > seems to make any reasonably clean solution impossible. Thoughts?
> > 
> > FWIW I'm planning to send a proposal to allow base:: types in core/ and
> modules/
> > next week.
> 
> Would that mean that we'll remove the current WTF wrappers for types that
we'll
> allow in Blink?

Yes. (Sorry for the delayed reply. It looks like I was kicked off from the cc
list.)

Powered by Google App Engine
This is Rietveld 408576698