Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2892953006: WIP POC blob transport over mojo

Created:
3 years, 7 months ago by Marijn Kruisselbrink
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, wjmaclean, creis+watch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, nasko+codewatch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, dglazkov+blink, darin-cc_chromium.org, blink-reviews, blink-reviews-api_chromium.org, darin (slow to review), kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP POC blob transport over mojo BUG=

Patch Set 1 #

Patch Set 2 : make gn check happy #

Patch Set 3 : make multiple datastreams work #

Patch Set 4 : gracefully fail when renderer dies #

Patch Set 5 : Move byte provider in blink out of worker thread, as worker thread may block. #

Patch Set 6 : use io runner rather than main thread for data transfer, as main runner can also block #

Patch Set 7 : make GetBlob from uuid work #

Patch Set 8 : fix a few more tests #

Patch Set 9 : pass mojo blobs over ipc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1150 lines, -8 lines) Patch
M content/browser/blob_storage/blob_dispatcher_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/blob_storage/chrome_blob_storage_context.h View 4 chunks +7 lines, -0 lines 0 comments Download
M content/browser/blob_storage/chrome_blob_storage_context.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/storage_partition_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/child/blob_storage/webblobregistry_impl.h View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M content/child/blob_storage/webblobregistry_impl.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M content/common/content_param_traits.h View 1 2 3 4 5 6 7 8 2 chunks +12 lines, -0 lines 0 comments Download
M content/common/content_param_traits.cc View 1 2 3 4 5 6 7 8 2 chunks +47 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_messages.h View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M content/common/service_worker/service_worker_types.h View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_types.cc View 1 2 3 4 5 6 7 8 1 chunk +35 lines, -2 lines 0 comments Download
M content/public/app/mojo/content_browser_manifest.json View 1 2 3 4 5 6 7 1 chunk +1 line, -0 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 2 chunks +23 lines, -0 lines 0 comments Download
M content/renderer/service_worker/service_worker_type_util.cc View 1 2 3 4 5 6 7 8 2 chunks +3 lines, -1 line 0 comments Download
M storage/browser/BUILD.gn View 1 2 chunks +8 lines, -0 lines 0 comments Download
A storage/browser/blob/blob_impl.h View 1 2 3 4 5 6 7 1 chunk +34 lines, -0 lines 0 comments Download
A storage/browser/blob/blob_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +39 lines, -0 lines 0 comments Download
A storage/browser/blob/blob_registry_impl.h View 1 2 3 1 chunk +83 lines, -0 lines 0 comments Download
A storage/browser/blob/blob_registry_impl.cc View 1 2 3 4 5 6 7 8 1 chunk +377 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/BUILD.gn View 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/blob/BlobBytesProvider.h View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/platform/blob/BlobBytesProvider.cpp View 1 2 3 1 chunk +162 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobData.h View 1 2 3 4 5 6 7 8 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobData.cpp View 1 2 3 4 5 6 7 5 chunks +117 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobRegistry.h View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/blob/BlobRegistry.cpp View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/exported/WebServiceWorkerResponse.cpp View 1 2 3 4 5 6 7 8 1 chunk +12 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 2 3 4 5 6 7 8 2 chunks +35 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebBlobRegistry.h View 1 2 3 4 5 2 chunks +6 lines, -0 lines 0 comments Download
A third_party/WebKit/public/platform/blobs.mojom View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerResponse.h View 1 2 3 4 5 6 7 8 2 chunks +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2887353004 Patch 1

Messages

Total messages: 32 (32 generated)
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-20 00:32:49 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892953006/1
3 years, 7 months ago (2017-05-20 00:33:38 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-20 00:39:19 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/272546) android_cronet on ...
3 years, 7 months ago (2017-05-20 00:39:20 UTC) #4
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-21 03:13:56 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892953006/20001
3 years, 7 months ago (2017-05-21 03:14:05 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-21 03:21:34 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/443300)
3 years, 7 months ago (2017-05-21 03:21:35 UTC) #8
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 18:23:44 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892953006/40001
3 years, 7 months ago (2017-05-22 18:28:24 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 18:39:58 UTC) #11
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/443971)
3 years, 7 months ago (2017-05-22 18:39:59 UTC) #12
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 21:25:41 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892953006/60001
3 years, 7 months ago (2017-05-22 21:26:20 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 21:36:11 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/444154)
3 years, 7 months ago (2017-05-22 21:36:12 UTC) #16
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 22:20:28 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892953006/80001
3 years, 7 months ago (2017-05-22 22:21:02 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 22:30:03 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/444223)
3 years, 7 months ago (2017-05-22 22:30:04 UTC) #20
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 23:24:31 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892953006/100001
3 years, 7 months ago (2017-05-22 23:25:19 UTC) #22
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 23:36:37 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/444308)
3 years, 7 months ago (2017-05-22 23:36:38 UTC) #24
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-22 23:43:15 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892953006/120001
3 years, 7 months ago (2017-05-22 23:43:44 UTC) #26
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-22 23:55:47 UTC) #27
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/444333)
3 years, 7 months ago (2017-05-22 23:55:48 UTC) #28
Marijn Kruisselbrink
The CQ bit was checked by mek@chromium.org to run a CQ dry run
3 years, 7 months ago (2017-05-23 20:50:56 UTC) #29
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892953006/140001
3 years, 7 months ago (2017-05-23 20:51:40 UTC) #30
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
3 years, 7 months ago (2017-05-23 21:03:37 UTC) #31
commit-bot: I haz the power
3 years, 7 months ago (2017-05-23 21:03:38 UTC) #32 
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698