Blink caret only if selection has focus.

Blink caret only if selection has focus.

Use Selection().SelectionHasFocus() in FrameCaret::ShouldBlinkCaret();

BUG=713051
Review-Url: https://codereview.chromium.org/2887303002
Cr-Commit-Position: refs/heads/master@{#473153}
Committed: https://chromium.googlesource.com/chromium/src/+/f56b768202fbf0ea253e350a43259781e453c48d

[yoichio, 2017-05-18 07:18:41]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 07:19:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-05-18 07:19:17]

yoichio@chromium.org changed reviewers:
+ yosin@chromium.org

[yoichio, 2017-05-18 07:19:18]

yosin, how do you test caret blinking?

[yosin_UTC9, 2017-05-18 07:30:44]

https://codereview.chromium.org/2887303002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/editing/FrameCaret.cpp (right):

https://codereview.chromium.org/2887303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/editing/FrameCaret.cpp:216: return
frame_->Selection().SelectionHasFocus();
Yes, this is what I expected.

When |focused_element_| is BODY, this function returns true for caret in
unfocused INPUT.

Hope no layout rest failures...

[commit-bot: I haz the power, 2017-05-18 09:55:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 09:55:45]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-05-19 00:56:02]

This patch will fix bug[1].

[1] http://crbug.com/723671 ⚐	Caret stays visible inside contentEditable when
other element is focused

[yoichio, 2017-05-19 06:04:13]

The CQ bit was checked by yoichio@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 06:04:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yoichio, 2017-05-19 06:05:04]

Description was changed from

==========
Blink caret only if selection has focus.

BUG=713051
==========

to

==========
Blink caret only if selection has focus.

Use Selection().SelectionHasFocus() in FrameCaret::ShouldBlinkCaret();

BUG=713051
==========

[yosin_UTC9, 2017-05-19 06:12:21]

lgtm w/ nit

https://codereview.chromium.org/2887303002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/FrameCaretTest.cpp (right):

https://codereview.chromium.org/2887303002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameCaretTest.cpp:91: const
SelectionInDOMTree& dom = Selection().GetSelectionInDOMTree();
nit: s/dom/selection/

It is "DOM Selection" instead of DOM = Document Object Model.

[commit-bot: I haz the power, 2017-05-19 07:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 07:58:35]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yoichio, 2017-05-19 08:00:19]

https://codereview.chromium.org/2887303002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/editing/FrameCaretTest.cpp (right):

https://codereview.chromium.org/2887303002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/FrameCaretTest.cpp:91: const
SelectionInDOMTree& dom = Selection().GetSelectionInDOMTree();
On 2017/05/19 06:12:21, yosin_UTC9 wrote:
> nit: s/dom/selection/
> 
> It is "DOM Selection" instead of DOM = Document Object Model.

Done.

[yoichio, 2017-05-19 08:00:22]

The CQ bit was checked by yoichio@chromium.org

[yoichio, 2017-05-19 08:00:23]

The patchset sent to the CQ was uploaded after l-g-t-m from yosin@chromium.org
Link to the patchset: https://codereview.chromium.org/2887303002/#ps40001
(title: "update")

[commit-bot: I haz the power, 2017-05-19 08:01:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 10:48:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1495180822804180,
"parent_rev": "5b593eae748eb6b7145dfbe0692a2b97536c1da9", "commit_rev":
"f56b768202fbf0ea253e350a43259781e453c48d"}

[commit-bot: I haz the power, 2017-05-19 10:48:57]

Description was changed from

==========
Blink caret only if selection has focus.

Use Selection().SelectionHasFocus() in FrameCaret::ShouldBlinkCaret();

BUG=713051
==========

to

==========
Blink caret only if selection has focus.

Use Selection().SelectionHasFocus() in FrameCaret::ShouldBlinkCaret();

BUG=713051

Review-Url: https://codereview.chromium.org/2887303002
Cr-Commit-Position: refs/heads/master@{#473153}
Committed:
https://chromium.googlesource.com/chromium/src/+/f56b768202fbf0ea253e350a4325...
==========

[commit-bot: I haz the power, 2017-05-19 10:48:58]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/f56b768202fbf0ea253e350a4325...