Blink caret only if selection has focus.

third_party/WebKit/Source/core/editing/FrameCaretTest.cpp

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/editing/FrameCaret.h"
 
 #include "core/editing/EditingTestBase.h"
 #include "core/editing/FrameSelection.h"
 #include "core/editing/commands/TypingCommand.h"
 #include "core/frame/FrameView.h"
 #include "core/layout/LayoutTheme.h"
 #include "core/page/FocusController.h"
 #include "platform/LayoutTestSupport.h"
 #include "platform/scheduler/test/fake_web_task_runner.h"
 
 namespace blink {
 
 class FrameCaretTest : public EditingTestBase {
  public:
   FrameCaretTest()
       : was_running_layout_test_(LayoutTestSupport::IsRunningLayoutTest()) {
     // The caret blink timer doesn't work if isRunningLayoutTest() because
     // LayoutTheme::caretBlinkInterval() returns 0.
     LayoutTestSupport::SetIsRunningLayoutTest(false);
   }
   ~FrameCaretTest() override {
     LayoutTestSupport::SetIsRunningLayoutTest(was_running_layout_test_);
   }
 
+  bool ShouldBlinkCaret(const FrameCaret& caret) {
+    return caret.ShouldBlinkCaret();
+  }
+
  private:
   const bool was_running_layout_test_;
 };
 
 TEST_F(FrameCaretTest, BlinkAfterTyping) {
   FrameCaret& caret = Selection().FrameCaretForTesting();
   RefPtr<scheduler::FakeWebTaskRunner> task_runner =
       AdoptRef(new scheduler::FakeWebTaskRunner);
   task_runner->SetTime(0);
   caret.RecreateCaretBlinkTimerForTesting(task_runner.Get());
@@ skipping 24 matching lines @@
   GetDocument().View()->UpdateAllLifecyclePhases();
   EXPECT_TRUE(caret.ShouldPaintCaretForTesting())
       << "The typing command reset the timer. The caret is still visible.";
 
   task_runner->AdvanceTimeAndRun(1);
   GetDocument().View()->UpdateAllLifecyclePhases();
   EXPECT_FALSE(caret.ShouldPaintCaretForTesting())
       << "The caret should blink after the typing command.";
 }
 
+TEST_F(FrameCaretTest, ShouldNotBlinkWhenSelectionLooseFocus) {
+  FrameCaret& caret = Selection().FrameCaretForTesting();
+  GetDocument().GetPage()->GetFocusController().SetActive(true);
+  GetDocument().GetPage()->GetFocusController().SetFocused(true);
+  GetDocument().body()->setInnerHTML(
+      "<div id='outer' tabindex='-1'>"
+      "<div id='input' contenteditable>foo</div>"
+      "</div>");
+  Element* input = GetDocument().QuerySelector("#input");
+  input->focus();
+  Element* outer = GetDocument().QuerySelector("#outer");
+  outer->focus();
+  GetDocument().View()->UpdateAllLifecyclePhases();
+  const SelectionInDOMTree& dom = Selection().GetSelectionInDOMTree();

[yosin_UTC9, 2017/05/19 06:12:21]

nit: s/dom/selection/

It is "DOM Selection" instead of DOM = Document Object Model.

[yoichio, 2017/05/19 08:00:18]

Done.

+  EXPECT_EQ(dom.Base(), Position(input, PositionAnchorType::kBeforeChildren));
+  EXPECT_FALSE(ShouldBlinkCaret(caret));
+}
+
 }  // namespace blink