Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Issue 2887263003: [ios clean] ToolsMenu ScrollView and Close Button (Closed)

Created:
3 years, 7 months ago by sczs
Modified:
3 years, 7 months ago
Reviewers:
edchin, lpromero
CC:
chromium-reviews, marq+scrutinize_chromium.org, lpromero+watch_chromium.org, ios-reviews+clean_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[ios clean] ToolsMenu ScrollView and Close Button ToolsMenu now scrolls and the close button is always floating in the corner. SS: https://drive.google.com/open?id=0Byo6-Nuda2jgemxMaUlxcUh0TDA BUG=682880 Review-Url: https://codereview.chromium.org/2887263003 Cr-Commit-Position: refs/heads/master@{#473365} Committed: https://chromium.googlesource.com/chromium/src/+/e9105e9bb16be5b830a0d6eae1fec84fedd49f24

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -26 lines) Patch
M ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm View 3 chunks +0 lines, -5 lines 0 comments Download
M ios/clean/chrome/browser/ui/tools/menu_view_controller.mm View 7 chunks +80 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
sczs
PTAL
3 years, 7 months ago (2017-05-18 15:24:48 UTC) #5
edchin
lgtm
3 years, 7 months ago (2017-05-19 21:41:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887263003/20001
3 years, 7 months ago (2017-05-19 22:12:49 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 22:26:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/e9105e9bb16be5b830a0d6eae1fe...

Powered by Google App Engine
This is Rietveld 408576698