ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm - Issue 2887263003: [ios clean] ToolsMenu ScrollView and Close Button

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm

Issue 2887263003: [ios clean] ToolsMenu ScrollView and Close Button (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.h ('k') | ios/clean/chrome/browser/ui/tools/menu_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm

diff --git a/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm b/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm

index 8a5836a9439407b44e65876dd9050b3c48ca7efe..d5c7f52804014e770c8e758a4a579bccdcd8fac8 100644

--- a/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm

+++ b/ios/clean/chrome/browser/ui/tools/menu_overflow_controls_stackview.mm

@@ -7,7 +7,6 @@

#import "ios/clean/chrome/browser/ui/toolbar/toolbar_button+factory.h"

@implementation MenuOverflowControlsStackView

-@synthesize toolsMenuButton = _toolsMenuButton;

@synthesize shareButton = _shareButton;

@synthesize reloadButton = _reloadButton;

@synthesize stopButton = _stopButton;

@@ -19,7 +18,6 @@

[self addArrangedSubview:self.shareButton];

[self addArrangedSubview:self.stopButton];

[self addArrangedSubview:self.reloadButton];

- [self addArrangedSubview:self.toolsMenuButton];

self.axis = UILayoutConstraintAxisHorizontal;

self.distribution = UIStackViewDistributionFillEqually;

@@ -30,9 +28,6 @@

#pragma mark - Components Setup

- (void)setUpToolbarButtons {

- // Tools menu button.

- self.toolsMenuButton = [ToolbarButton toolsMenuToolbarButton];

// Share button.

self.shareButton = [ToolbarButton shareToolbarButton];