Compile file_manager and eliminate gyp v1 from Files App!

Compile file_manager and eliminate gyp v1 from Files App!

TEST=run_compiler
BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2890123003
Cr-Commit-Position: refs/heads/master@{#473210}
Committed: https://chromium.googlesource.com/chromium/src/+/e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3

[oka, 2017-05-18 18:19:06]

Description was changed from

==========
Compile file_manager and eliminate gyp v1 from Files App!

TEST=run_compiler
BUG=636289
==========

to

==========
Compile file_manager and eliminate gyp v1 from Files App!

TEST=run_compiler
BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2017-05-18 18:46:07]

.

[oka, 2017-05-18 18:51:27]

oka@chromium.org changed reviewers:
+ dbeam@chromium.org, fukino@chromium.org

[oka, 2017-05-18 18:51:28]

PTAL.

dbeam@ for third_party/closure_compiler/closure_compiler.gyp

fukino@ for the others.

[oka, 2017-05-18 19:00:21]

Rebase.

[Dan Beam, 2017-05-18 19:36:28]

whoohoo! lgtm!

i'll make a followup CL that removes all the compiled_resources.gyp files

[oka, 2017-05-18 20:20:11]

Compile main too.

[fukino, 2017-05-19 04:54:56]

Woo-foo! LGTM!!!

[oka, 2017-05-19 09:59:36]

The CQ bit was checked by oka@chromium.org

[oka, 2017-05-19 09:59:37]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2890123003/#ps60001
(title: "Compile main too.")

[oka, 2017-05-19 09:59:37]

The CQ bit was unchecked by oka@chromium.org

[oka, 2017-05-19 09:59:43]

The CQ bit was checked by oka@chromium.org

[oka, 2017-05-19 09:59:44]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2890123003/#ps60001
(title: "Compile main too.")

[commit-bot: I haz the power, 2017-05-19 10:00:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 11:51:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 11:51:11]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oka, 2017-05-19 15:58:23]

Fix test failures. Format.

[oka, 2017-05-19 15:58:34]

The CQ bit was checked by oka@chromium.org

[oka, 2017-05-19 15:58:34]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org,
fukino@chromium.org
Link to the patchset: https://codereview.chromium.org/2890123003/#ps80001
(title: "Fix test failures. Format.")

[commit-bot: I haz the power, 2017-05-19 15:59:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 16:28:00]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1495209514167070,
"parent_rev": "2e545f253b342d81a9c2c27a83a0d08a1a0ab3ed", "commit_rev":
"e7dea2c1da0cb2ec88b3f13a6891db1ee7f7e0a3"}

[commit-bot: I haz the power, 2017-05-19 16:28:12]

Description was changed from

==========
Compile file_manager and eliminate gyp v1 from Files App!

TEST=run_compiler
BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Compile file_manager and eliminate gyp v1 from Files App!

TEST=run_compiler
BUG=636289
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2890123003
Cr-Commit-Position: refs/heads/master@{#473210}
Committed:
https://chromium.googlesource.com/chromium/src/+/e7dea2c1da0cb2ec88b3f13a6891...
==========

[commit-bot: I haz the power, 2017-05-19 16:28:13]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e7dea2c1da0cb2ec88b3f13a6891...