Make EnabledDelete return false for user-triggered command and unfocused selection

Make EnabledDelete return false for user-triggered command and unfocused selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledDelete() to fix
the behavior of the 'Delete' command.

BUG=722925
TEST=editing/deleting/delete_with_unfocsed_selection.html

Review-Url: https://codereview.chromium.org/2887213002
Cr-Commit-Position: refs/heads/master@{#472644}
Committed: https://chromium.googlesource.com/chromium/src/+/f1eefca818771900ae2977d86952d42cb3b7fcb2

[Xiaocheng, 2017-05-17 20:04:08]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 20:04:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-17 20:05:09]

Description was changed from

==========
Make EnabledDelete return false for user-triggered command and unfocused
selection


BUG=
==========

to

==========
Make EnabledDelete return false for user-triggered command and unfocused
selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledDelete() to fix
the behavior of the 'Delete' command.

BUG=722925
TEST=editing/deleting/delete_with_unfocsed_selection.html
==========

[commit-bot: I haz the power, 2017-05-17 22:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 22:06:40]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Xiaocheng, 2017-05-17 23:01:03]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 23:03:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-05-18 00:08:05]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2017-05-18 00:08:05]

PTAL.

[yosin_UTC9, 2017-05-18 01:00:11]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-05-18 01:00:14]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-05-18 01:00:14]

lgtm

[commit-bot: I haz the power, 2017-05-18 01:01:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 03:43:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495069214351530, "parent_rev":
"0d7d2b26b79f0d75280911e80ccc22c77fe80cb5", "commit_rev":
"f1eefca818771900ae2977d86952d42cb3b7fcb2"}

[commit-bot: I haz the power, 2017-05-18 03:43:17]

Description was changed from

==========
Make EnabledDelete return false for user-triggered command and unfocused
selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledDelete() to fix
the behavior of the 'Delete' command.

BUG=722925
TEST=editing/deleting/delete_with_unfocsed_selection.html
==========

to

==========
Make EnabledDelete return false for user-triggered command and unfocused
selection

Certain editing commands shouldn't be enabled when they are user-triggered and
the selection doesn't have focus. This patch adds checking of
FrameSelection::SelectionHasFocus() in EnabledDelete() to fix
the behavior of the 'Delete' command.

BUG=722925
TEST=editing/deleting/delete_with_unfocsed_selection.html

Review-Url: https://codereview.chromium.org/2887213002
Cr-Commit-Position: refs/heads/master@{#472644}
Committed:
https://chromium.googlesource.com/chromium/src/+/f1eefca818771900ae2977d86952...
==========

[commit-bot: I haz the power, 2017-05-18 03:43:18]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f1eefca818771900ae2977d86952...