Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1613)

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2887213002: Make EnabledDelete return false for user-triggered command and unfocused selection (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/deleting/delete_with_unfocused_selection.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
index 03772a7b444d0c8704633a5c36e56cc5c05b2ec2..813d5f992f8045363614ab95afa2a12924b6126e 100644
--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
@@ -2068,7 +2068,8 @@ static bool EnabledDelete(LocalFrame& frame,
EditorCommandSource source) {
switch (source) {
case kCommandFromMenuOrKeyBinding:
- return frame.GetEditor().CanDelete();
+ return frame.Selection().SelectionHasFocus() &&
+ frame.GetEditor().CanDelete();
case kCommandFromDOM:
// "Delete" from DOM is like delete/backspace keypress, affects selected
// range if non-empty, otherwise removes a character
« no previous file with comments | « third_party/WebKit/LayoutTests/editing/deleting/delete_with_unfocused_selection.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698