Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2887173002:
Fix DCHECK to account for child SVG objects not having PaintLayers. (Closed)
|
Created:
3 years, 7 months ago by chrishtr Modified:
3 years, 7 months ago Reviewers:
Xianzhu CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix DCHECK to account for child SVG objects not having PaintLayers.
BUG=723285
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2887173002
Cr-Commit-Position: refs/heads/master@{#472719}
Committed: https://chromium.googlesource.com/chromium/src/+/c13e012c60b19fbc1d8166e3bcd2448830e1bf84
Patch Set 1 #Patch Set 2 : none #
Total comments: 2
Patch Set 3 : none #Patch Set 4 : Merge branch 'master' into foreignobjectcrash #
Messages
Total messages: 22 (15 generated)
Description was changed from ========== none BUG= ========== to ========== none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Fix DCHECK to account for child SVG objects not having PaintLayers. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
chrishtr@chromium.org changed reviewers: + wangxianzhu@chromium.org
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Description was changed from ========== Fix DCHECK to account for child SVG objects not having PaintLayers. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Fix DCHECK to account for child SVG objects not having PaintLayers. BUG=723285 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm https://codereview.chromium.org/2887173002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/svg/clip-path/clip-path-foreign-object-crash.html (right): https://codereview.chromium.org/2887173002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/clip-path/clip-path-foreign-object-crash.html:1: <!doctype HTML> Does "*-crash.html" automatically avoid the text expectation? Or do we need to make it a harness test?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
https://codereview.chromium.org/2887173002/diff/20001/third_party/WebKit/Layo... File third_party/WebKit/LayoutTests/svg/clip-path/clip-path-foreign-object-crash.html (right): https://codereview.chromium.org/2887173002/diff/20001/third_party/WebKit/Layo... third_party/WebKit/LayoutTests/svg/clip-path/clip-path-foreign-object-crash.html:1: <!doctype HTML> On 2017/05/17 at 19:44:33, Xianzhu wrote: > Does "*-crash.html" automatically avoid the text expectation? Or do we need to make it a harness test? Good point, fixed.
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2887173002/#ps40001 (title: "none")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2887173002/#ps60001 (title: "Merge branch 'master' into foreignobjectcrash")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495070335789080,
"parent_rev": "1b8803f36fd6e7d05cd0ab2f943e7fbefc90012b", "commit_rev":
"c13e012c60b19fbc1d8166e3bcd2448830e1bf84"}
Message was sent while issue was closed.
Description was changed from ========== Fix DCHECK to account for child SVG objects not having PaintLayers. BUG=723285 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Fix DCHECK to account for child SVG objects not having PaintLayers. BUG=723285 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2887173002 Cr-Commit-Position: refs/heads/master@{#472719} Committed: https://chromium.googlesource.com/chromium/src/+/c13e012c60b19fbc1d8166e3bcd2... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/c13e012c60b19fbc1d8166e3bcd2... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
