third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp - Issue 2887173002: Fix DCHECK to account for child SVG objects not having PaintLayers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2887173002: Fix DCHECK to account for child SVG objects not having PaintLayers. (Closed)

Patch Set: Merge branch 'master' into foreignobjectcrash Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

index c8f3f1db5a3cff773419d8e7fc1d10631c5cee93..5c613db689626b254e520fedd5af301006d512b6 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

@@ -52,7 +52,8 @@ static const PaintLayer* FindParentLayerOnClippingContainerChain(

// SVG (other than LayoutSVGRoot) cannot have PaintLayers.

DCHECK(!current->HasClipRelatedProperty() ||

current->StyleRef().ContainsPaint() ||

- (current->IsBox() && ToLayoutBox(current)->HasControlClip()));

+ (current->IsBox() && ToLayoutBox(current)->HasControlClip()) ||

+ current->IsSVGChild());

}

NOTREACHED();

return nullptr;

« no previous file with comments | « third_party/WebKit/LayoutTests/svg/clip-path/clip-path-foreign-object-crash.html ('k') | no next file » | no next file with comments »