Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 2887153006: Pull loader.[cc|h] file out of libdart_builtin rule and instead include it in each of the targets (… (Closed)

Created:
3 years, 7 months ago by siva
Modified:
3 years, 7 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Pull loader.[cc|h] file out of libdart_builtin rule and instead include it in each of the targets (dart|gen_snapshot|dart_bootstrap) that need it. It is not needed in dart_precompiled_runtime but to really remove it from there some refactoring of main.cc is needed. This CL does not address that. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/92a516e70325d6668c58c592457bfe0ffce744a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M runtime/bin/BUILD.gn View 4 chunks +11 lines, -1 line 0 comments Download
M runtime/bin/bin.gypi View 5 chunks +10 lines, -0 lines 0 comments Download
M runtime/bin/builtin_impl_sources.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
siva
3 years, 7 months ago (2017-05-18 22:39:51 UTC) #2
rmacnak
lgtm
3 years, 7 months ago (2017-05-18 23:43:16 UTC) #3
siva
3 years, 7 months ago (2017-05-19 20:27:48 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92a516e70325d6668c58c592457bfe0ffce744a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698