runtime/bin/bin.gypi - Issue 2887153006: Pull loader.[cc|h] file out of libdart_builtin rule and instead include it in each of the targets (…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/bin.gypi

Issue 2887153006: Pull loader.[cc|h] file out of libdart_builtin rule and instead include it in each of the targets (… (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/bin.gypi

diff --git a/runtime/bin/bin.gypi b/runtime/bin/bin.gypi

index f5e2a631a761c1e8365c83de721583756f9611fc..dad18bd61d76f09415af869dacc7808b2c3c2753 100644

--- a/runtime/bin/bin.gypi

+++ b/runtime/bin/bin.gypi

@@ -953,6 +953,8 @@

'builtin_common.cc',

'builtin.cc',

'builtin.h',

+ 'loader.cc',

+ 'loader.h',

'platform_android.cc',

'platform_linux.cc',

'platform_macos.cc',

@@ -1131,6 +1133,8 @@

'error_exit.h',

'io_natives.h',

'main.cc',

+ 'loader.cc',

+ 'loader.h',

'snapshot_utils.cc',

'snapshot_utils.h',

'vmservice_impl.cc',

@@ -1194,6 +1198,8 @@

'error_exit.h',

'io_natives.h',

'main.cc',

+ 'loader.cc',

+ 'loader.h',

'snapshot_empty.cc',

'snapshot_utils.cc',

'snapshot_utils.h',

@@ -1244,6 +1250,8 @@

'error_exit.h',

'io_natives.h',

'main.cc',

+ 'loader.cc',

+ 'loader.h',

'observatory_assets_empty.cc',

'snapshot_empty.cc',

'snapshot_utils.cc',

@@ -1325,6 +1333,8 @@

'builtin_nolib.cc',

'builtin.h',

'io_natives.h',

+ 'loader.cc',

+ 'loader.h',

# Include generated source files.

'<(snapshot_cc_file)',

'<(builtin_cc_file)',

« no previous file with comments | « runtime/bin/BUILD.gn ('k') | runtime/bin/builtin_impl_sources.gypi » ('j') | no next file with comments »