Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Side by Side Diff: runtime/bin/BUILD.gn

Issue 2887153006: Pull loader.[cc|h] file out of libdart_builtin rule and instead include it in each of the targets (… (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 # for details. All rights reserved. Use of this source code is governed by a 2 # for details. All rights reserved. Use of this source code is governed by a
3 # BSD-style license that can be found in the LICENSE file. 3 # BSD-style license that can be found in the LICENSE file.
4 4
5 import("gypi_contents.gni") 5 import("gypi_contents.gni")
6 import("../runtime_args.gni") 6 import("../runtime_args.gni")
7 import("../../build/compiled_action.gni") 7 import("../../build/compiled_action.gni")
8 8
9 # Generate a resources.cc file for the service isolate without Observatory. 9 # Generate a resources.cc file for the service isolate without Observatory.
10 action("gen_resources_cc") { 10 action("gen_resources_cc") {
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 280
281 sources = [ 281 sources = [
282 # Include generated source files. 282 # Include generated source files.
283 "$target_gen_dir/builtin_gen.cc", 283 "$target_gen_dir/builtin_gen.cc",
284 "$target_gen_dir/io_gen.cc", 284 "$target_gen_dir/io_gen.cc",
285 "$target_gen_dir/io_patch_gen.cc", 285 "$target_gen_dir/io_patch_gen.cc",
286 "$target_gen_dir/resources_gen.cc", 286 "$target_gen_dir/resources_gen.cc",
287 "address_sanitizer.cc", 287 "address_sanitizer.cc",
288 "builtin.cc", 288 "builtin.cc",
289 "builtin.h", 289 "builtin.h",
290 "loader.cc",
291 "loader.h",
290 292
291 # Very limited native resolver provided. 293 # Very limited native resolver provided.
292 "builtin_common.cc", 294 "builtin_common.cc",
293 "builtin_gen_snapshot.cc", 295 "builtin_gen_snapshot.cc",
294 "gen_snapshot.cc", 296 "gen_snapshot.cc",
295 "vmservice_impl.cc", 297 "vmservice_impl.cc",
296 "vmservice_impl.h", 298 "vmservice_impl.h",
297 ] 299 ]
298 300
299 include_dirs = [ ".." ] 301 include_dirs = [ ".." ]
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
611 } 613 }
612 } 614 }
613 } 615 }
614 616
615 dart_executable("dart") { 617 dart_executable("dart") {
616 extra_deps = [ 618 extra_deps = [
617 "..:libdart_jit", 619 "..:libdart_jit",
618 ":dart_snapshot_cc", 620 ":dart_snapshot_cc",
619 "../observatory:standalone_observatory_archive", 621 "../observatory:standalone_observatory_archive",
620 ] 622 ]
621 extra_sources = [ "builtin_nolib.cc" ] 623 extra_sources = [
624 "builtin_nolib.cc",
625 "loader.cc",
626 "loader.h",
627 ]
622 } 628 }
623 629
624 dart_executable("dart_precompiled_runtime") { 630 dart_executable("dart_precompiled_runtime") {
625 extra_configs = [ "..:dart_precompiled_runtime_config" ] 631 extra_configs = [ "..:dart_precompiled_runtime_config" ]
626 extra_deps = [ 632 extra_deps = [
627 "..:libdart_precompiled_runtime", 633 "..:libdart_precompiled_runtime",
628 "../observatory:standalone_observatory_archive", 634 "../observatory:standalone_observatory_archive",
629 ] 635 ]
630 extra_sources = [ 636 extra_sources = [
631 "builtin_nolib.cc", 637 "builtin_nolib.cc",
632 "snapshot_empty.cc", 638 "snapshot_empty.cc",
639 "loader.cc",
640 "loader.h",
633 ] 641 ]
634 } 642 }
635 643
636 dart_executable("dart_bootstrap") { 644 dart_executable("dart_bootstrap") {
637 extra_configs = [ 645 extra_configs = [
638 "..:dart_precompiler_config", 646 "..:dart_precompiler_config",
639 "..:dart_no_snapshot_config", 647 "..:dart_no_snapshot_config",
640 ] 648 ]
641 extra_deps = [ 649 extra_deps = [
642 ":generate_builtin_cc_file", 650 ":generate_builtin_cc_file",
(...skipping 10 matching lines...) Expand all
653 ":generate_metadata_cc_file", 661 ":generate_metadata_cc_file",
654 ":generate_web_sql_cc_file", 662 ":generate_web_sql_cc_file",
655 ":generate_svg_cc_file", 663 ":generate_svg_cc_file",
656 ":generate_web_audio_cc_file", 664 ":generate_web_audio_cc_file",
657 "..:libdart_nosnapshot_with_precompiler", 665 "..:libdart_nosnapshot_with_precompiler",
658 ] 666 ]
659 extra_defines = [ "NO_OBSERVATORY" ] 667 extra_defines = [ "NO_OBSERVATORY" ]
660 extra_sources = [ 668 extra_sources = [
661 "builtin.cc", 669 "builtin.cc",
662 "builtin.h", 670 "builtin.h",
671 "loader.cc",
672 "loader.h",
663 "observatory_assets_empty.cc", 673 "observatory_assets_empty.cc",
664 "snapshot_empty.cc", 674 "snapshot_empty.cc",
665 675
666 # Include generated source files. 676 # Include generated source files.
667 "$target_gen_dir/builtin_gen.cc", 677 "$target_gen_dir/builtin_gen.cc",
668 "$target_gen_dir/io_gen.cc", 678 "$target_gen_dir/io_gen.cc",
669 "$target_gen_dir/io_patch_gen.cc", 679 "$target_gen_dir/io_patch_gen.cc",
670 "$target_gen_dir/html_gen.cc", 680 "$target_gen_dir/html_gen.cc",
671 "$target_gen_dir/html_common_gen.cc", 681 "$target_gen_dir/html_common_gen.cc",
672 "$target_gen_dir/js_gen.cc", 682 "$target_gen_dir/js_gen.cc",
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
851 ] 861 ]
852 if (is_linux || is_android) { 862 if (is_linux || is_android) {
853 cflags = [ "-fPIC" ] 863 cflags = [ "-fPIC" ]
854 } 864 }
855 if (is_win) { 865 if (is_win) {
856 libs = [ "dart.lib" ] 866 libs = [ "dart.lib" ]
857 abs_root_out_dir = rebase_path(root_out_dir) 867 abs_root_out_dir = rebase_path(root_out_dir)
858 ldflags = [ "/LIBPATH:$abs_root_out_dir" ] 868 ldflags = [ "/LIBPATH:$abs_root_out_dir" ]
859 } 869 }
860 } 870 }
OLDNEW
« no previous file with comments | « no previous file | runtime/bin/bin.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698