DescriptionReland of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService (patchset #1 id:1 of https://codereview.chromium.org/2892563002/ )
Reason for revert:
This was not the cause of the failure, which has been fixed by reverting other CLs. See BUG for details.
Original issue's description:
> Revert of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService (patchset #1 id:1 of https://codereview.chromium.org/2884163002/ )
>
> Reason for revert:
> Layout tests failure ; mojo/module-loading(-manual-deps-loading).html
>
> BUG=723461
>
> Original issue's description:
> > media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService
> >
> > Previously InterfaceFactoryImpl instances are using SrongBinding such
> > that they will only be destroyed on connection error. However, we could
> > hit an issue when MediaService is being destructed, the MojoMediaClient
> > is already destroyed, and an InterfaceFactoryImpl still tries to access
> > the MojoMediaClient.
> >
> > This CL ensures that when MediaService is being destructed, all
> > InterfaceFactoryImpl will also be destroyed to avoid the issue.
> >
> > BUG=721965
> >
> > Review-Url: https://codereview.chromium.org/2884163002
> > Cr-Commit-Position: refs/heads/master@{#472261}
> > Committed: https://chromium.googlesource.com/chromium/src/+/5223bd13f8a97e293361a3b9b2cc31101ba597da
>
> TBR=alokp@chromium.org,xhwang@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=721965
>
> Review-Url: https://codereview.chromium.org/2892563002
> Cr-Commit-Position: refs/heads/master@{#472405}
> Committed: https://chromium.googlesource.com/chromium/src/+/0ca49acbd1483c0e82be1a546168c5740231d908
TBR=alokp@chromium.org,kolos@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=723461
Review-Url: https://codereview.chromium.org/2887153002
Cr-Commit-Position: refs/heads/master@{#472469}
Committed: https://chromium.googlesource.com/chromium/src/+/ecb8e8c1f22d894ac2fcec89a968f248b988d8c5
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|