Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1299)

Issue 2887153002: Reland of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService (Closed)

Created:
3 years, 7 months ago by xhwang
Modified:
3 years, 7 months ago
Reviewers:
kolos1, alokp
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService (patchset #1 id:1 of https://codereview.chromium.org/2892563002/ ) Reason for revert: This was not the cause of the failure, which has been fixed by reverting other CLs. See BUG for details. Original issue's description: > Revert of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService (patchset #1 id:1 of https://codereview.chromium.org/2884163002/ ) > > Reason for revert: > Layout tests failure ; mojo/module-loading(-manual-deps-loading).html > > BUG=723461 > > Original issue's description: > > media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService > > > > Previously InterfaceFactoryImpl instances are using SrongBinding such > > that they will only be destroyed on connection error. However, we could > > hit an issue when MediaService is being destructed, the MojoMediaClient > > is already destroyed, and an InterfaceFactoryImpl still tries to access > > the MojoMediaClient. > > > > This CL ensures that when MediaService is being destructed, all > > InterfaceFactoryImpl will also be destroyed to avoid the issue. > > > > BUG=721965 > > > > Review-Url: https://codereview.chromium.org/2884163002 > > Cr-Commit-Position: refs/heads/master@{#472261} > > Committed: https://chromium.googlesource.com/chromium/src/+/5223bd13f8a97e293361a3b9b2cc31101ba597da > > TBR=alokp@chromium.org,xhwang@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=721965 > > Review-Url: https://codereview.chromium.org/2892563002 > Cr-Commit-Position: refs/heads/master@{#472405} > Committed: https://chromium.googlesource.com/chromium/src/+/0ca49acbd1483c0e82be1a546168c5740231d908 TBR=alokp@chromium.org,kolos@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=723461 Review-Url: https://codereview.chromium.org/2887153002 Cr-Commit-Position: refs/heads/master@{#472469} Committed: https://chromium.googlesource.com/chromium/src/+/ecb8e8c1f22d894ac2fcec89a968f248b988d8c5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M media/mojo/services/media_service.h View 2 chunks +3 lines, -0 lines 0 comments Download
M media/mojo/services/media_service.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
xhwang
Created Reland of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService
3 years, 7 months ago (2017-05-17 16:19:20 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887153002/1
3 years, 7 months ago (2017-05-17 16:19:53 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 16:20:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ecb8e8c1f22d894ac2fcec89a968...

Powered by Google App Engine
This is Rietveld 408576698