DescriptionRevert of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService (patchset #1 id:1 of https://codereview.chromium.org/2884163002/ )
Reason for revert:
Layout tests failure ; mojo/module-loading(-manual-deps-loading).html
BUG=723461
Original issue's description:
> media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService
>
> Previously InterfaceFactoryImpl instances are using SrongBinding such
> that they will only be destroyed on connection error. However, we could
> hit an issue when MediaService is being destructed, the MojoMediaClient
> is already destroyed, and an InterfaceFactoryImpl still tries to access
> the MojoMediaClient.
>
> This CL ensures that when MediaService is being destructed, all
> InterfaceFactoryImpl will also be destroyed to avoid the issue.
>
> BUG=721965
>
> Review-Url: https://codereview.chromium.org/2884163002
> Cr-Commit-Position: refs/heads/master@{#472261}
> Committed: https://chromium.googlesource.com/chromium/src/+/5223bd13f8a97e293361a3b9b2cc31101ba597da
TBR=alokp@chromium.org,xhwang@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=721965
Review-Url: https://codereview.chromium.org/2892563002
Cr-Commit-Position: refs/heads/master@{#472405}
Committed: https://chromium.googlesource.com/chromium/src/+/0ca49acbd1483c0e82be1a546168c5740231d908
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|