Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2892563002: Revert of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService (Closed)

Created:
3 years, 7 months ago by kolos1
Modified:
3 years, 7 months ago
Reviewers:
xhwang, alokp
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService (patchset #1 id:1 of https://codereview.chromium.org/2884163002/ ) Reason for revert: Layout tests failure ; mojo/module-loading(-manual-deps-loading).html BUG=723461 Original issue's description: > media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService > > Previously InterfaceFactoryImpl instances are using SrongBinding such > that they will only be destroyed on connection error. However, we could > hit an issue when MediaService is being destructed, the MojoMediaClient > is already destroyed, and an InterfaceFactoryImpl still tries to access > the MojoMediaClient. > > This CL ensures that when MediaService is being destructed, all > InterfaceFactoryImpl will also be destroyed to avoid the issue. > > BUG=721965 > > Review-Url: https://codereview.chromium.org/2884163002 > Cr-Commit-Position: refs/heads/master@{#472261} > Committed: https://chromium.googlesource.com/chromium/src/+/5223bd13f8a97e293361a3b9b2cc31101ba597da TBR=alokp@chromium.org,xhwang@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=721965 Review-Url: https://codereview.chromium.org/2892563002 Cr-Commit-Position: refs/heads/master@{#472405} Committed: https://chromium.googlesource.com/chromium/src/+/0ca49acbd1483c0e82be1a546168c5740231d908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M media/mojo/services/media_service.h View 2 chunks +0 lines, -3 lines 0 comments Download
M media/mojo/services/media_service.cc View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
kolos1
Created Revert of media: Use StrongBindingSet for InterfaceFactoryImpl in MediaService
3 years, 7 months ago (2017-05-17 09:58:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2892563002/1
3 years, 7 months ago (2017-05-17 09:59:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/0ca49acbd1483c0e82be1a546168c5740231d908
3 years, 7 months ago (2017-05-17 10:00:15 UTC) #6
xhwang
3 years, 7 months ago (2017-05-17 16:19:19 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2887153002/ by xhwang@chromium.org.

The reason for reverting is: This was not the cause of the failure, which has
been fixed by reverting other CLs. See BUG for details..

Powered by Google App Engine
This is Rietveld 408576698