Chromium Code Reviews
DescriptionRevert of Refactor backdrop (patchset #6 id:220001 of https://codereview.chromium.org/2884623002/ )
Reason for revert:
FindIt detected this CL as culprit.
https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/21215
Original issue's description:
> Refactor backdrop that is currently used in the maximized mode.
>
> The maximized mode creates a backdrop window so that a user will not see the content of windows behind the top window,
> in case it doesn't cover the entire window. (can happen if the maximize size is specified for example)
> This CL generalizes the backdrop code used in maximize mode as to create the backdrop in the following scenarios:
>
> 1) Has a aura::client::kHasBackdrop property = true.
> 2) BackdropDelegate::HasBackdrop(aura::Window* window) returns true.
> 3) Active ARC window when the spoken feedback is enabled.
>
>
> * Added delegate to check if the window should have a backdrop.
> Maximized mode always puts a backdrop.
>
> * Added kHasBackdrop property for a window that needs a backdrop even in clamshell.
>
> * Move the accessibility feature implemented in exo's backbround. This
> is useful and should be there even for non-arc/exo case.
>
> BUG=721646
> TEST=coverted by unit tests
>
> Review-Url: https://codereview.chromium.org/2884623002
> Cr-Commit-Position: refs/heads/master@{#472401}
> Committed: https://chromium.googlesource.com/chromium/src/+/04936c54ed2396ae54cd824e24f11151e0e11948
TBR=reveman@chromium.org,jamescook@chromium.org,sky@chromium.org,oshima@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=721646
Review-Url: https://codereview.chromium.org/2887103002
Cr-Commit-Position: refs/heads/master@{#472436}
Committed: https://chromium.googlesource.com/chromium/src/+/b59e8df0bf51b0de1d7924d96bfebfbb2705ddc3
Patch Set 1 #Messages
Total messages: 6 (3 generated)
|