Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2887103002: Revert of Refactor backdrop (Closed)

Created:
3 years, 7 months ago by kolos1
Modified:
3 years, 7 months ago
Reviewers:
reveman, James Cook, oshima, sky
CC:
chromium-reviews, dcheng, kalyank, sadrul, Mr4D (OOO till 08-26)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Refactor backdrop (patchset #6 id:220001 of https://codereview.chromium.org/2884623002/ ) Reason for revert: FindIt detected this CL as culprit. https://findit-for-me.appspot.com/waterfall/build-failure?url=https://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/21215 Original issue's description: > Refactor backdrop that is currently used in the maximized mode. > > The maximized mode creates a backdrop window so that a user will not see the content of windows behind the top window, > in case it doesn't cover the entire window. (can happen if the maximize size is specified for example) > This CL generalizes the backdrop code used in maximize mode as to create the backdrop in the following scenarios: > > 1) Has a aura::client::kHasBackdrop property = true. > 2) BackdropDelegate::HasBackdrop(aura::Window* window) returns true. > 3) Active ARC window when the spoken feedback is enabled. > > > * Added delegate to check if the window should have a backdrop. > Maximized mode always puts a backdrop. > > * Added kHasBackdrop property for a window that needs a backdrop even in clamshell. > > * Move the accessibility feature implemented in exo's backbround. This > is useful and should be there even for non-arc/exo case. > > BUG=721646 > TEST=coverted by unit tests > > Review-Url: https://codereview.chromium.org/2884623002 > Cr-Commit-Position: refs/heads/master@{#472401} > Committed: https://chromium.googlesource.com/chromium/src/+/04936c54ed2396ae54cd824e24f11151e0e11948 TBR=reveman@chromium.org,jamescook@chromium.org,sky@chromium.org,oshima@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=721646 Review-Url: https://codereview.chromium.org/2887103002 Cr-Commit-Position: refs/heads/master@{#472436} Committed: https://chromium.googlesource.com/chromium/src/+/b59e8df0bf51b0de1d7924d96bfebfbb2705ddc3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+568 lines, -781 lines) Patch
M ash/BUILD.gn View 4 chunks +3 lines, -5 lines 0 comments Download
M ash/test/workspace_controller_test_api.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/test/workspace_controller_test_api.cc View 2 chunks +0 lines, -6 lines 0 comments Download
D ash/wm/maximize_mode/maximize_mode_backdrop_delegate_impl.h View 1 chunk +0 lines, -27 lines 0 comments Download
D ash/wm/maximize_mode/maximize_mode_backdrop_delegate_impl.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_window_manager.cc View 4 chunks +20 lines, -4 lines 0 comments Download
A ash/wm/maximize_mode/workspace_backdrop_delegate.h View 1 chunk +65 lines, -0 lines 0 comments Download
A ash/wm/maximize_mode/workspace_backdrop_delegate.cc View 1 chunk +133 lines, -0 lines 0 comments Download
D ash/wm/workspace/backdrop_controller.h View 1 chunk +0 lines, -116 lines 0 comments Download
D ash/wm/workspace/backdrop_controller.cc View 1 chunk +0 lines, -244 lines 0 comments Download
D ash/wm/workspace/backdrop_delegate.h View 1 chunk +0 lines, -28 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.h View 4 chunks +4 lines, -9 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager.cc View 8 chunks +24 lines, -23 lines 0 comments Download
A ash/wm/workspace/workspace_layout_manager_backdrop_delegate.h View 1 chunk +45 lines, -0 lines 0 comments Download
M ash/wm/workspace/workspace_layout_manager_unittest.cc View 7 chunks +10 lines, -258 lines 0 comments Download
M ash/wm/workspace_controller.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ash/wm/workspace_controller.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M components/exo/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/exo/shell_surface.h View 3 chunks +5 lines, -0 lines 0 comments Download
M components/exo/shell_surface.cc View 8 chunks +81 lines, -11 lines 0 comments Download
M components/exo/shell_surface_unittest.cc View 6 chunks +104 lines, -19 lines 0 comments Download
M components/exo/wm_helper.h View 5 chunks +14 lines, -0 lines 0 comments Download
M components/exo/wm_helper.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M components/exo/wm_helper_ash.h View 4 chunks +8 lines, -0 lines 0 comments Download
M components/exo/wm_helper_ash.cc View 5 chunks +16 lines, -0 lines 0 comments Download
M components/exo/wm_helper_mus.h View 1 chunk +2 lines, -0 lines 0 comments Download
M components/exo/wm_helper_mus.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/aura/client/aura_constants.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
kolos1
Created Revert of Refactor backdrop
3 years, 7 months ago (2017-05-17 13:15:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2887103002/1
3 years, 7 months ago (2017-05-17 13:16:21 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 13:17:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b59e8df0bf51b0de1d7924d96bfe...

Powered by Google App Engine
This is Rietveld 408576698