Layout Most Visited for ContentSuggestions

Layout Most Visited for ContentSuggestions

Layout the Most Visited tiles to have them displayed as wanted in the
ContentSuggestions view.
It displays them as individual cells, maximum 4 by rows.

BUG=707754
Review-Url: https://codereview.chromium.org/2887073002
Cr-Commit-Position: refs/heads/master@{#472712}
Committed: https://chromium.googlesource.com/chromium/src/+/77cd7e79cf24ddef0c1a40c3f5497eb125432aee

[gambard, 2017-05-17 07:24:15]

gambard@chromium.org changed reviewers:
+ lod@chromium.org

[gambard, 2017-05-17 07:24:15]

PTAL.

[lody, 2017-05-17 08:23:34]

https://codereview.chromium.org/2887073002/diff/1/ios/chrome/browser/ui/conte...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
(right):

https://codereview.chromium.org/2887073002/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm:153:
if ([self.collectionUpdater isMostVisitedSection:indexPath.section])
It looks like single-line ifs in this file use { }

[gambard, 2017-05-17 09:39:43]

Thanks, PTAL :)

https://codereview.chromium.org/2887073002/diff/1/ios/chrome/browser/ui/conte...
File
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm
(right):

https://codereview.chromium.org/2887073002/diff/1/ios/chrome/browser/ui/conte...
ios/chrome/browser/ui/content_suggestions/content_suggestions_view_controller.mm:153:
if ([self.collectionUpdater isMostVisitedSection:indexPath.section])
On 2017/05/17 08:23:33, lody wrote:
> It looks like single-line ifs in this file use { } 

Done.

[lody, 2017-05-17 09:40:29]

lgtm

[gambard, 2017-05-17 14:15:01]

The CQ bit was checked by gambard@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 14:15:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 15:54:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 15:54:03]

Dry run: This issue passed the CQ dry run.

[gambard, 2017-05-18 06:34:26]

The CQ bit was checked by gambard@chromium.org

[commit-bot: I haz the power, 2017-05-18 06:35:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 06:41:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495089266368250,
"parent_rev": "c5bff5bfdf04b0831f7ba4a976e8e5401523bd85", "commit_rev":
"77cd7e79cf24ddef0c1a40c3f5497eb125432aee"}

[commit-bot: I haz the power, 2017-05-18 06:41:49]

Description was changed from

==========
Layout Most Visited for ContentSuggestions

Layout the Most Visited tiles to have them displayed as wanted in the
ContentSuggestions view.
It displays them as individual cells, maximum 4 by rows.

BUG=707754
==========

to

==========
Layout Most Visited for ContentSuggestions

Layout the Most Visited tiles to have them displayed as wanted in the
ContentSuggestions view.
It displays them as individual cells, maximum 4 by rows.

BUG=707754

Review-Url: https://codereview.chromium.org/2887073002
Cr-Commit-Position: refs/heads/master@{#472712}
Committed:
https://chromium.googlesource.com/chromium/src/+/77cd7e79cf24ddef0c1a40c3f549...
==========

[commit-bot: I haz the power, 2017-05-18 06:41:50]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/77cd7e79cf24ddef0c1a40c3f549...