Print Preview: Migrate some JS tests to use Mocha.

Print Preview: Migrate some JS tests to use Mocha.

Migrated following tests (and also shortened names to be less verbose)

TestPrinterList -> PrinterList
TestPrinterListCloudEmpty -> PrinterListCloudEmpty
TestPrintPreviewRestoreLocalDestination -> RestoreLocalDestination
TestPrintPreviewRestoreMultipleDestinations -> RestoreMultipleDestinations
TestPrintPreviewDefaultDestinationSelectionRules -> DefaultDestinationSelectionRules

Migrated tests 5, remaining tests 31.

BUG=726536
Review-Url: https://codereview.chromium.org/2887003002
Cr-Commit-Position: refs/heads/master@{#475118}
Committed: https://chromium.googlesource.com/chromium/src/+/fa46590a75919b4892df4d26074cf074bd79b048

[dpapad, 2017-05-25 23:24:21]

Description was changed from

==========
Print Preview: Add dummy Mocha test.

BUG=None
==========

to

==========
Print Preview: Migrate some JS tests to use Mocha.

BUG=None
==========

[dpapad, 2017-05-25 23:24:26]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[dpapad, 2017-05-25 23:25:24]

Description was changed from

==========
Print Preview: Migrate some JS tests to use Mocha.

BUG=None
==========

to

==========
Print Preview: Migrate some JS tests to use Mocha.

Migrating the following tests:

 TestPrinterList -> PrinterList

BUG=None
==========

[commit-bot: I haz the power, 2017-05-25 23:25:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-05-25 23:27:56]

Description was changed from

==========
Print Preview: Migrate some JS tests to use Mocha.

BUG=None
==========

to

==========
Print Preview: Migrate some JS tests to use Mocha.

TestPrinterList -> PrinterList
TestPrinterListCloudEmpty -> PrinterListCloudEmpty
TestPrintPreviewRestoreLocalDestination -> RestoreLocalDestination
TestPrintPreviewRestoreMultipleDestinations -> RestoreMultipleDestinations
TestPrintPreviewDefaultDestinationSelectionRules ->
DefaultDestinationSelectionRules

BUG=None
==========

[dpapad, 2017-05-25 23:34:29]

Description was changed from

==========
Print Preview: Migrate some JS tests to use Mocha.

TestPrinterList -> PrinterList
TestPrinterListCloudEmpty -> PrinterListCloudEmpty
TestPrintPreviewRestoreLocalDestination -> RestoreLocalDestination
TestPrintPreviewRestoreMultipleDestinations -> RestoreMultipleDestinations
TestPrintPreviewDefaultDestinationSelectionRules ->
DefaultDestinationSelectionRules

BUG=None
==========

to

==========
Print Preview: Migrate some JS tests to use Mocha.

TestPrinterList -> PrinterList
TestPrinterListCloudEmpty -> PrinterListCloudEmpty
TestPrintPreviewRestoreLocalDestination -> RestoreLocalDestination
TestPrintPreviewRestoreMultipleDestinations -> RestoreMultipleDestinations
TestPrintPreviewDefaultDestinationSelectionRules ->
DefaultDestinationSelectionRules

BUG=726536
==========

[dpapad, 2017-05-25 23:35:51]

Description was changed from

==========
Print Preview: Migrate some JS tests to use Mocha.

TestPrinterList -> PrinterList
TestPrinterListCloudEmpty -> PrinterListCloudEmpty
TestPrintPreviewRestoreLocalDestination -> RestoreLocalDestination
TestPrintPreviewRestoreMultipleDestinations -> RestoreMultipleDestinations
TestPrintPreviewDefaultDestinationSelectionRules ->
DefaultDestinationSelectionRules

BUG=726536
==========

to

==========
Print Preview: Migrate some JS tests to use Mocha.

TestPrinterList -> PrinterList
TestPrinterListCloudEmpty -> PrinterListCloudEmpty
TestPrintPreviewRestoreLocalDestination -> RestoreLocalDestination
TestPrintPreviewRestoreMultipleDestinations -> RestoreMultipleDestinations
TestPrintPreviewDefaultDestinationSelectionRules ->
DefaultDestinationSelectionRules

Migrated tests 5, remaining tests 31.

BUG=726536
==========

[dpapad, 2017-05-25 23:36:18]

Description was changed from

==========
Print Preview: Migrate some JS tests to use Mocha.

TestPrinterList -> PrinterList
TestPrinterListCloudEmpty -> PrinterListCloudEmpty
TestPrintPreviewRestoreLocalDestination -> RestoreLocalDestination
TestPrintPreviewRestoreMultipleDestinations -> RestoreMultipleDestinations
TestPrintPreviewDefaultDestinationSelectionRules ->
DefaultDestinationSelectionRules

Migrated tests 5, remaining tests 31.

BUG=726536
==========

to

==========
Print Preview: Migrate some JS tests to use Mocha.

Migrated following tests (and also shortened names to be less verbose)

TestPrinterList -> PrinterList
TestPrinterListCloudEmpty -> PrinterListCloudEmpty
TestPrintPreviewRestoreLocalDestination -> RestoreLocalDestination
TestPrintPreviewRestoreMultipleDestinations -> RestoreMultipleDestinations
TestPrintPreviewDefaultDestinationSelectionRules ->
DefaultDestinationSelectionRules

Migrated tests 5, remaining tests 31.

BUG=726536
==========

[dpapad, 2017-05-25 23:47:16]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-25 23:47:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dpapad, 2017-05-26 00:49:24]

dpapad@chromium.org changed reviewers:
+ rbpotter@chromium.org

[dpapad, 2017-05-26 00:49:26]

https://codereview.chromium.org/2887003002/diff/120001/chrome/test/data/webui...
File chrome/test/data/webui/print_preview/print_preview_tests.js (right):

https://codereview.chromium.org/2887003002/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:38: function
setInitialSettings() {
Migrated helper methods from print_preview.js here, and simplified some of them
where possible. Temporarily some of them appear both here and in
print_preview.js. Once the migration is done, the goal is to delete
chrome/test/data/print_preview/print_preview.js completely.

[rbpotter, 2017-05-26 01:34:25]

lgtm

https://codereview.chromium.org/2887003002/diff/120001/chrome/test/data/webui...
File chrome/test/data/webui/print_preview/print_preview_tests.js (right):

https://codereview.chromium.org/2887003002/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:57: * @device - The
device whose capabilities should be dispatched.
@device should probably be updated to @param { ... } device but there
is not yet a typedef for the CAPABILITIES_SET response. It will need
to be defined when we move 'getPrinterCapabilities' to
cr.sendWithPromise so maybe we should wait until then.

https://codereview.chromium.org/2887003002/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:78: function
getCddTemplate(printerId) {
@param {string} printerId
@return {...} same response type that is not yet defined.

https://codereview.chromium.org/2887003002/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:245: origin:
'local',
It is like this in the original test also, but wondering if since
the change to ChromeOS destinations this should have the same
cr.isChromeOS ? 'chrome_os' : 'local' logic as in the test below.

[dpapad, 2017-05-26 18:14:07]

https://codereview.chromium.org/2887003002/diff/120001/chrome/test/data/webui...
File chrome/test/data/webui/print_preview/print_preview_tests.js (right):

https://codereview.chromium.org/2887003002/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:57: * @device - The
device whose capabilities should be dispatched.
On 2017/05/26 at 01:34:25, rbpotter wrote:
> @device should probably be updated to @param { ... } device but there
> is not yet a typedef for the CAPABILITIES_SET response. It will need
> to be defined when we move 'getPrinterCapabilities' to
> cr.sendWithPromise so maybe we should wait until then.

Changed to @param {!Object} for now, and planning to update it once the typedef
is in place.

https://codereview.chromium.org/2887003002/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:78: function
getCddTemplate(printerId) {
On 2017/05/26 at 01:34:24, rbpotter wrote:
> @param {string} printerId
> @return {...} same response type that is not yet defined.

Done. Using @param {!Object} for now, as in previous comment.

https://codereview.chromium.org/2887003002/diff/120001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:245: origin:
'local',
On 2017/05/26 at 01:34:25, rbpotter wrote:
> It is like this in the original test also, but wondering if since
> the change to ChromeOS destinations this should have the same
> cr.isChromeOS ? 'chrome_os' : 'local' logic as in the test below.

Done.

[dpapad, 2017-05-26 18:47:12]

https://codereview.chromium.org/2887003002/diff/200001/chrome/test/data/webui...
File chrome/test/data/webui/print_preview/print_preview_tests.js (right):

https://codereview.chromium.org/2887003002/diff/200001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:126:
suiteSetup(function() {
Migrated the logic to replace CloudPrintInterface and checkPluginCompatibility_
too. I verified that the latter is actually called by the tests. Could not
verify that CloudPrintInterface#search is called during
PrinterListCloudPrintEmpty test (even before the Mocha migration).

[dpapad, 2017-05-26 18:49:37]

The CQ bit was checked by dpapad@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-26 18:50:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rbpotter, 2017-05-26 18:59:33]

still lgtm.

https://codereview.chromium.org/2887003002/diff/200001/chrome/test/data/webui...
File chrome/test/data/webui/print_preview/print_preview_tests.js (right):

https://codereview.chromium.org/2887003002/diff/200001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:126:
suiteSetup(function() {
On 2017/05/26 18:47:12, dpapad wrote:
> Migrated the logic to replace CloudPrintInterface and
checkPluginCompatibility_
> too. I verified that the latter is actually called by the tests. Could not
> verify that CloudPrintInterface#search is called during
> PrinterListCloudPrintEmpty test (even before the Mocha migration).

It seems like the only thing that should trigger the
search() call is an account change happening from
the destination search overlay. I am not sure how that
would be triggered during the tests, which is probably
why it is not called. Possibly there was another path
to search when the cloud print test was added?

[dpapad, 2017-05-26 19:24:20]

https://codereview.chromium.org/2887003002/diff/200001/chrome/test/data/webui...
File chrome/test/data/webui/print_preview/print_preview_tests.js (right):

https://codereview.chromium.org/2887003002/diff/200001/chrome/test/data/webui...
chrome/test/data/webui/print_preview/print_preview_tests.js:126:
suiteSetup(function() {
> It seems like the only thing that should trigger the
> search() call is an account change happening from
> the destination search overlay. I am not sure how that
> would be triggered during the tests, which is probably
> why it is not called. Possibly there was another path
> to search when the cloud print test was added?

Looking at the original CL who added that code,
https://codereview.chromium.org/10108001/diff/109004/chrome/test/data/webui/p...
(5 years ago), it does not seem that search() was ever called during testing.
Instead a SEARH_DONE event is manually fired to test the code that responds to
that event. We can probbaly clean that up once we change the way
CloudPrintInterface is replaced during tests.

[commit-bot: I haz the power, 2017-05-26 20:35:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-26 20:35:19]

Dry run: This issue passed the CQ dry run.

[dpapad, 2017-05-26 20:45:18]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2017-05-26 20:45:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-26 20:49:58]

CQ is committing da patch.

Bot data: {"patchset_id": 200001, "attempt_start_ts": 1495831518361970,
"parent_rev": "e5f7fdd10814d38c50e90700d2cf67fec0b8bcd2", "commit_rev":
"fa46590a75919b4892df4d26074cf074bd79b048"}

[commit-bot: I haz the power, 2017-05-26 20:50:09]

Description was changed from

==========
Print Preview: Migrate some JS tests to use Mocha.

Migrated following tests (and also shortened names to be less verbose)

TestPrinterList -> PrinterList
TestPrinterListCloudEmpty -> PrinterListCloudEmpty
TestPrintPreviewRestoreLocalDestination -> RestoreLocalDestination
TestPrintPreviewRestoreMultipleDestinations -> RestoreMultipleDestinations
TestPrintPreviewDefaultDestinationSelectionRules ->
DefaultDestinationSelectionRules

Migrated tests 5, remaining tests 31.

BUG=726536
==========

to

==========
Print Preview: Migrate some JS tests to use Mocha.

Migrated following tests (and also shortened names to be less verbose)

TestPrinterList -> PrinterList
TestPrinterListCloudEmpty -> PrinterListCloudEmpty
TestPrintPreviewRestoreLocalDestination -> RestoreLocalDestination
TestPrintPreviewRestoreMultipleDestinations -> RestoreMultipleDestinations
TestPrintPreviewDefaultDestinationSelectionRules ->
DefaultDestinationSelectionRules

Migrated tests 5, remaining tests 31.

BUG=726536

Review-Url: https://codereview.chromium.org/2887003002
Cr-Commit-Position: refs/heads/master@{#475118}
Committed:
https://chromium.googlesource.com/chromium/src/+/fa46590a75919b4892df4d26074c...
==========

[commit-bot: I haz the power, 2017-05-26 20:50:10]

Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/fa46590a75919b4892df4d26074c...