Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2910503003:
Print Preview: Migrate JS tests to use Mocha, part 2. (Closed)
DescriptionPrint Preview: Migrate JS tests to use Mocha, part 2.
Migrating following tests:
SystemDialogLinkIsHiddenInAppKioskMode
SectionsDisabled
PrintToPDFSelectedCapabilities
SourceIsHTMLCapabilities
SourceIsPDFCapabilities
ScalingUnchecksFitToPage
CheckNumCopiesPrintPreset
CheckDuplexPrintPreset
CustomMarginsControlsCheck
PageLayoutHasNoMarginsHideHeaderFooter
PageLayoutHasMarginsShowHeaderFooter
Migrated tests 16, remaining tests 20.
BUG=726536
Review-Url: https://codereview.chromium.org/2910503003
Cr-Commit-Position: refs/heads/master@{#475217}
Committed: https://chromium.googlesource.com/chromium/src/+/4a225601e7fcf2c57ea5376edf1e55e722216343
Patch Set 1 #Patch Set 2 : Nit #
Total comments: 7
Patch Set 3 : Address comments. #
Depends on Patchset: Messages
Total messages: 25 (19 generated)
Description was changed from ========== Print Preview: Migrate JS tests to use Mocha, part 2. BUG=726536 ========== to ========== Print Preview: Migrate JS tests to use Mocha, part 2. Migrating following tests: SystemDialogLinkIsHiddenInAppKioskMode SectionsDisabled PrintToPDFSelectedCapabilities SourceIsHTMLCapabilities SourceIsPDFCapabilities ScalingUnchecksFitToPage CheckNumCopiesPrintPreset CheckDuplexPrintPreset CustomMarginsControlsCheck PageLayoutHasNoMarginsHideHeaderFooter PageLayoutHasMarginsShowHeaderFooter BUG=726536 ==========
Description was changed from ========== Print Preview: Migrate JS tests to use Mocha, part 2. Migrating following tests: SystemDialogLinkIsHiddenInAppKioskMode SectionsDisabled PrintToPDFSelectedCapabilities SourceIsHTMLCapabilities SourceIsPDFCapabilities ScalingUnchecksFitToPage CheckNumCopiesPrintPreset CheckDuplexPrintPreset CustomMarginsControlsCheck PageLayoutHasNoMarginsHideHeaderFooter PageLayoutHasMarginsShowHeaderFooter BUG=726536 ========== to ========== Print Preview: Migrate JS tests to use Mocha, part 2. Migrating following tests: SystemDialogLinkIsHiddenInAppKioskMode SectionsDisabled PrintToPDFSelectedCapabilities SourceIsHTMLCapabilities SourceIsPDFCapabilities ScalingUnchecksFitToPage CheckNumCopiesPrintPreset CheckDuplexPrintPreset CustomMarginsControlsCheck PageLayoutHasNoMarginsHideHeaderFooter PageLayoutHasMarginsShowHeaderFooter BUG=726536 ==========
Description was changed from ========== Print Preview: Migrate JS tests to use Mocha, part 2. Migrating following tests: SystemDialogLinkIsHiddenInAppKioskMode SectionsDisabled PrintToPDFSelectedCapabilities SourceIsHTMLCapabilities SourceIsPDFCapabilities ScalingUnchecksFitToPage CheckNumCopiesPrintPreset CheckDuplexPrintPreset CustomMarginsControlsCheck PageLayoutHasNoMarginsHideHeaderFooter PageLayoutHasMarginsShowHeaderFooter BUG=726536 ========== to ========== Print Preview: Migrate JS tests to use Mocha, part 2. Migrating following tests: SystemDialogLinkIsHiddenInAppKioskMode SectionsDisabled PrintToPDFSelectedCapabilities SourceIsHTMLCapabilities SourceIsPDFCapabilities ScalingUnchecksFitToPage CheckNumCopiesPrintPreset CheckDuplexPrintPreset CustomMarginsControlsCheck PageLayoutHasNoMarginsHideHeaderFooter PageLayoutHasMarginsShowHeaderFooter BUG=726536 ==========
Description was changed from ========== Print Preview: Migrate JS tests to use Mocha, part 2. Migrating following tests: SystemDialogLinkIsHiddenInAppKioskMode SectionsDisabled PrintToPDFSelectedCapabilities SourceIsHTMLCapabilities SourceIsPDFCapabilities ScalingUnchecksFitToPage CheckNumCopiesPrintPreset CheckDuplexPrintPreset CustomMarginsControlsCheck PageLayoutHasNoMarginsHideHeaderFooter PageLayoutHasMarginsShowHeaderFooter BUG=726536 ========== to ========== Print Preview: Migrate JS tests to use Mocha, part 2. Migrating following tests: SystemDialogLinkIsHiddenInAppKioskMode SectionsDisabled PrintToPDFSelectedCapabilities SourceIsHTMLCapabilities SourceIsPDFCapabilities ScalingUnchecksFitToPage CheckNumCopiesPrintPreset CheckDuplexPrintPreset CustomMarginsControlsCheck PageLayoutHasNoMarginsHideHeaderFooter PageLayoutHasMarginsShowHeaderFooter Migrated tests 16, remaining tests 20. BUG=726536 ==========
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dpapad@chromium.org changed reviewers: + rbpotter@chromium.org
Green tests at patch #1.
https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... File chrome/test/data/webui/print_preview/print_preview_tests.js (right): https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... chrome/test/data/webui/print_preview/print_preview_tests.js:89: function checkElementDisplayed(el, isDisplayed) { @param {HTMLElement} el @param {boolean} isDisplayed https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... chrome/test/data/webui/print_preview/print_preview_tests.js:192: createPrintPreview(); See comment below. If the second call in the "SectionsDisabled" test is not needed it is possible this function may not need to be migrated. https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... chrome/test/data/webui/print_preview/print_preview_tests.js:406: createPrintPreview(); It looks like this is called in setup() already. Does it need to be called again here? https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... chrome/test/data/webui/print_preview/print_preview_tests.js:491: setCapabilities(getCddTemplate("FooDevice")); optional: set to single quotes for consistency with change in TestSystemDialogLinkIsHiddenInAppKioskMode above (same with next few tests).
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #3 (id:40001) has been deleted
https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... File chrome/test/data/webui/print_preview/print_preview_tests.js (right): https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... chrome/test/data/webui/print_preview/print_preview_tests.js:89: function checkElementDisplayed(el, isDisplayed) { On 2017/05/26 at 18:50:17, rbpotter wrote: > @param {HTMLElement} el > @param {boolean} isDisplayed Done. https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... chrome/test/data/webui/print_preview/print_preview_tests.js:406: createPrintPreview(); On 2017/05/26 at 18:50:17, rbpotter wrote: > It looks like this is called in setup() already. Does it need to be > called again here? Removed. It looks that it is not needed. https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... chrome/test/data/webui/print_preview/print_preview_tests.js:491: setCapabilities(getCddTemplate("FooDevice")); On 2017/05/26 at 18:50:17, rbpotter wrote: > optional: set to single quotes for consistency with change in > TestSystemDialogLinkIsHiddenInAppKioskMode above (same with > next few tests). Done.
The CQ bit was checked by dpapad@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/05/26 18:57:54, dpapad wrote: > https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... > File chrome/test/data/webui/print_preview/print_preview_tests.js (right): > > https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... > chrome/test/data/webui/print_preview/print_preview_tests.js:89: function > checkElementDisplayed(el, isDisplayed) { > On 2017/05/26 at 18:50:17, rbpotter wrote: > > @param {HTMLElement} el > > @param {boolean} isDisplayed > > Done. > > https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... > chrome/test/data/webui/print_preview/print_preview_tests.js:406: > createPrintPreview(); > On 2017/05/26 at 18:50:17, rbpotter wrote: > > It looks like this is called in setup() already. Does it need to be > > called again here? > > Removed. It looks that it is not needed. > > https://codereview.chromium.org/2910503003/diff/20001/chrome/test/data/webui/... > chrome/test/data/webui/print_preview/print_preview_tests.js:491: > setCapabilities(getCddTemplate("FooDevice")); > On 2017/05/26 at 18:50:17, rbpotter wrote: > > optional: set to single quotes for consistency with change in > > TestSystemDialogLinkIsHiddenInAppKioskMode above (same with > > next few tests). > > Done. lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dpapad@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495850197153110,
"parent_rev": "23c963cd61e359cc18548e1c2ed6116fdfbe4fdc", "commit_rev":
"4a225601e7fcf2c57ea5376edf1e55e722216343"}
Message was sent while issue was closed.
Description was changed from ========== Print Preview: Migrate JS tests to use Mocha, part 2. Migrating following tests: SystemDialogLinkIsHiddenInAppKioskMode SectionsDisabled PrintToPDFSelectedCapabilities SourceIsHTMLCapabilities SourceIsPDFCapabilities ScalingUnchecksFitToPage CheckNumCopiesPrintPreset CheckDuplexPrintPreset CustomMarginsControlsCheck PageLayoutHasNoMarginsHideHeaderFooter PageLayoutHasMarginsShowHeaderFooter Migrated tests 16, remaining tests 20. BUG=726536 ========== to ========== Print Preview: Migrate JS tests to use Mocha, part 2. Migrating following tests: SystemDialogLinkIsHiddenInAppKioskMode SectionsDisabled PrintToPDFSelectedCapabilities SourceIsHTMLCapabilities SourceIsPDFCapabilities ScalingUnchecksFitToPage CheckNumCopiesPrintPreset CheckDuplexPrintPreset CustomMarginsControlsCheck PageLayoutHasNoMarginsHideHeaderFooter PageLayoutHasMarginsShowHeaderFooter Migrated tests 16, remaining tests 20. BUG=726536 Review-Url: https://codereview.chromium.org/2910503003 Cr-Commit-Position: refs/heads/master@{#475217} Committed: https://chromium.googlesource.com/chromium/src/+/4a225601e7fcf2c57ea5376edf1e... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as https://chromium.googlesource.com/chromium/src/+/4a225601e7fcf2c57ea5376edf1e... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
