Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 2886943008: Revert of Shape Detection: Face detection junit tests (Closed)

Created:
3 years, 7 months ago by Marc Treib
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, junwei, nasko+codewatch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Shape Detection: Face detection junit tests (patchset #4 id:180001 of https://codereview.chromium.org/2863773005/ ) Reason for revert: The news tests are flaky, they've failed in 3 out of 4 runs right now: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests Original issue's description: > Shape Detection: Face detection junit tests > > This CL adds two robolectric Junit tests: > > - one for SharedBufferUtils, which tests error conditions such > as unmappable buffer, wrong dimensions, or wrong map()ped size > > - one for Face Detection, that verifies that the given callback > is called with the appropriate arguments in a series of cases. > This test is parameterized with a boolean indicating fast-mode > or not. > > Added alongside the (relatively new) service_junit_tests. > > BUG=722931 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2863773005 > Cr-Commit-Position: refs/heads/master@{#472679} > Committed: https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3c355e19a9f3d TBR=rockot@chromium.org,scheib@chromium.org,mcasas@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=722931 Review-Url: https://codereview.chromium.org/2886943008 Cr-Commit-Position: refs/heads/master@{#472748} Committed: https://chromium.googlesource.com/chromium/src/+/e268ff50e685b07e22e4c1d2e59d70e93c36a1a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -330 lines) Patch
M services/BUILD.gn View 1 chunk +1 line, -12 lines 0 comments Download
M services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImpl.java View 4 chunks +2 lines, -16 lines 0 comments Download
D services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java View 1 chunk +0 lines, -222 lines 0 comments Download
D services/shape_detection/android/junit/src/org/chromium/shape_detection/SharedBufferUtilsTest.java View 1 chunk +0 lines, -80 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Marc Treib
Created Revert of Shape Detection: Face detection junit tests
3 years, 7 months ago (2017-05-18 09:05:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886943008/1
3 years, 7 months ago (2017-05-18 09:06:13 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 09:06:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e268ff50e685b07e22e4c1d2e59d...

Powered by Google App Engine
This is Rietveld 408576698