Shape Detection: Face detection junit tests

Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such 
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases. 
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2863773005
Cr-Commit-Position: refs/heads/master@{#472679}
Committed: https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3c355e19a9f3d

[mcasas, 2017-05-06 05:08:57]

Description was changed from

==========
[wip]Shape Detection: Face detection junit tests


BUG=718275
==========

to

==========
[wip]Shape Detection: Face detection junit tests


BUG=718275
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-05-06 19:41:26]

Patchset #1 (id:1) has been deleted

[mcasas, 2017-05-06 19:55:36]

Patchset #1 (id:20001) has been deleted

[mcasas, 2017-05-06 20:35:54]

Patchset #1 (id:40001) has been deleted

[mcasas, 2017-05-15 23:50:18]

Patchset #1 (id:60001) has been deleted

[mcasas, 2017-05-16 18:06:29]

Patchset #1 (id:80001) has been deleted

[mcasas, 2017-05-16 18:06:33]

Patchset #1 (id:100001) has been deleted

[mcasas, 2017-05-16 18:09:20]

Description was changed from

==========
[wip]Shape Detection: Face detection junit tests


BUG=718275
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such 
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases. 
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=718275
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-05-16 18:15:17]

Description was changed from

==========
Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such 
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases. 
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=718275
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such 
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases. 
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[mcasas, 2017-05-16 18:16:24]

mcasas@chromium.org changed reviewers:
+ scheib@chromium.org

[mcasas, 2017-05-16 18:16:24]

scheib@ PTAL

[scheib, 2017-05-17 00:55:39]

LGTM, some thoughts:

https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti...
File
services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java
(right):

https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti...
services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java:77:
public void testConstruction() {
Just testing that the member variable  mFaceDetectionImpl  works?

https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti...
services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java:89:
SharedBufferHandle handle = Mockito.mock(SharedBufferHandle.class);
renaming handle -> sharedBuffer would be clearer.

[mcasas, 2017-05-17 01:09:43]

mcasas@chromium.org changed reviewers:
+ rockot@chromium.org

[mcasas, 2017-05-17 01:09:43]

rockot@ RS plz

 (will address scheib@ concerns later on)

[Ken Rockot(use gerrit already), 2017-05-17 15:59:14]

rs lgtm

[mcasas, 2017-05-17 16:54:03]

https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti...
File
services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java
(right):

https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti...
services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java:77:
public void testConstruction() {
On 2017/05/17 00:55:39, scheib wrote:
> Just testing that the member variable  mFaceDetectionImpl  works?

Yes, also because |options| in l.60 is parameterized.

https://codereview.chromium.org/2863773005/diff/120001/services/shape_detecti...
services/shape_detection/android/junit/src/org/chromium/shape_detection/FaceDetectionImplTest.java:89:
SharedBufferHandle handle = Mockito.mock(SharedBufferHandle.class);
On 2017/05/17 00:55:39, scheib wrote:
> renaming handle -> sharedBuffer would be clearer.

Done.

[mcasas, 2017-05-17 16:54:09]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-17 16:55:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 17:58:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 17:58:12]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mcasas, 2017-05-17 19:03:59]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-05-17 19:04:00]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2863773005/#ps160001
(title: "Increase timeout, because linux_android_rel_ng can be very slow")

[commit-bot: I haz the power, 2017-05-17 19:05:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mcasas, 2017-05-17 20:09:44]

The CQ bit was unchecked by mcasas@chromium.org

[mcasas, 2017-05-17 20:10:56]

The CQ bit was checked by mcasas@chromium.org

[mcasas, 2017-05-17 20:10:57]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2863773005/#ps180001
(title: "setFaceDetector() should be a static method (from findBugs)")

[commit-bot: I haz the power, 2017-05-17 20:11:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 21:07:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:07:45]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[mcasas, 2017-05-17 21:11:56]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-17 21:13:42]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 05:15:54]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1495055516399750,
"parent_rev": "f134db33d0941e7d89ab862455bf17e0b490fc88", "commit_rev":
"5bd36b1f586432d4b127d956a4b3c355e19a9f3d"}

[commit-bot: I haz the power, 2017-05-18 05:16:04]

Description was changed from

==========
Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such 
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases. 
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
Shape Detection: Face detection junit tests

This CL adds two robolectric Junit tests:

- one for SharedBufferUtils, which tests error conditions such 
 as unmappable buffer, wrong dimensions, or wrong map()ped size

- one for Face Detection, that verifies that the given callback
 is called with the appropriate arguments in a series of cases. 
 This test is parameterized with a boolean indicating fast-mode
 or not.

Added alongside the (relatively new) service_junit_tests.

BUG=722931
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2863773005
Cr-Commit-Position: refs/heads/master@{#472679}
Committed:
https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3...
==========

[commit-bot: I haz the power, 2017-05-18 05:16:06]

Committed patchset #4 (id:180001) as
https://chromium.googlesource.com/chromium/src/+/5bd36b1f586432d4b127d956a4b3...

[Marc Treib, 2017-05-18 09:05:40]

A revert of this CL (patchset #4 id:180001) has been created in
https://codereview.chromium.org/2886943008/ by treib@chromium.org.

The reason for reverting is: The news tests are flaky, they've failed in 3 out
of 4 runs right now:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests.