ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: nocompile test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/download/download_stats.cc ('K') | « content/renderer/input/render_widget_input_handler.cc ('k') | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | ios/chrome/today_extension/today_view_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm

diff --git a/ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm b/ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm

index a05bbb414f8993d00dd73ac647b03853294b54f3..55891fe0b5eb34f44f4f921f474ee635e11f0e55 100644

--- a/ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm

+++ b/ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm

@@ -163,8 +163,9 @@ enum PhysicalWebInitialStateIosChrome {

}

DCHECK(state < PHYSICAL_WEB_INITIAL_STATE_COUNT);

- UMA_HISTOGRAM_ENUMERATION("PhysicalWeb.InitialState.IosChrome", state,

- PHYSICAL_WEB_INITIAL_STATE_COUNT);

+ UMA_HISTOGRAM_EXACT_LINEAR(

+ "PhysicalWeb.InitialState.IosChrome", state,

+ static_cast<int>(PHYSICAL_WEB_INITIAL_STATE_COUNT));

Alexei Svitkine (slow) 2017/05/31 20:22:24 Can this use PhysicalWebInitialState instead? Sinc

wychen 2017/07/14 23:18:44 Used PhysicalWebInitialStateIosChrome.

}

@end