Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

content/browser/download/download_stats.cc

Index: content/browser/download/download_stats.cc
diff --git a/content/browser/download/download_stats.cc b/content/browser/download/download_stats.cc
index ea49d2da425ca54d2bf1a2ebee2c2b918853b4ef..797e94a52623221b76ef9588f22ee70f04ef6220 100644
--- a/content/browser/download/download_stats.cc
+++ b/content/browser/download/download_stats.cc
@@ -914,11 +914,13 @@ void RecordSavePackageEvent(SavePackageEvent event) {
 void RecordOriginStateOnResumption(bool is_partial,
                                    int state) {
   if (is_partial)
-    UMA_HISTOGRAM_ENUMERATION("Download.OriginStateOnPartialResumption", state,
-                              ORIGIN_STATE_ON_RESUMPTION_MAX);
+    UMA_HISTOGRAM_EXACT_LINEAR(
+        "Download.OriginStateOnPartialResumption", state,
+        static_cast<int>(ORIGIN_STATE_ON_RESUMPTION_MAX));

[Alexei Svitkine (slow), 2017/05/31 20:22:24]

But these are actual enums, as defined in XML.

I don't think we should be changing to use EXACT_LINEAR macro when logically
these are enums. Can the types of the function params be updated instead?

[wychen, 2017/07/14 23:18:44]

Fixed. Some static casts are still needed because this enum is inherently a
bitmask.

   else
-    UMA_HISTOGRAM_ENUMERATION("Download.OriginStateOnFullResumption", state,
-                              ORIGIN_STATE_ON_RESUMPTION_MAX);
+    UMA_HISTOGRAM_EXACT_LINEAR(
+        "Download.OriginStateOnFullResumption", state,
+        static_cast<int>(ORIGIN_STATE_ON_RESUMPTION_MAX));
 }
 
 namespace {