ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm - Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ios/chrome/browser/physical_web/physical_web_initial_state_recorder.mm

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)

Patch Set: nocompile test Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« content/browser/download/download_stats.cc ('K') | « content/renderer/input/render_widget_input_handler.cc ('k') | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | ios/chrome/today_extension/today_view_controller.mm » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #import "ios/chrome/browser/physical_web/physical_web_initial_state_recorder.h"	5 #import "ios/chrome/browser/physical_web/physical_web_initial_state_recorder.h"

6	6

7 #import <CoreBluetooth/CoreBluetooth.h>	7 #import <CoreBluetooth/CoreBluetooth.h>

8 #import <CoreLocation/CoreLocation.h>	8 #import <CoreLocation/CoreLocation.h>

9	9

10 #include "base/mac/scoped_nsobject.h"	10 #include "base/mac/scoped_nsobject.h"

(...skipping 145 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
156 state \|= LOCATION_SERVICES_FLAG;	156 state \|= LOCATION_SERVICES_FLAG;

157 }	157 }

158 if (locationAuthorized) {	158 if (locationAuthorized) {

159 state \|= LOCATION_AUTHORIZED_FLAG;	159 state \|= LOCATION_AUTHORIZED_FLAG;

160 }	160 }

161 if (bluetoothEnabled) {	161 if (bluetoothEnabled) {

162 state \|= BLUETOOTH_FLAG;	162 state \|= BLUETOOTH_FLAG;

163 }	163 }

164	164

165 DCHECK(state < PHYSICAL_WEB_INITIAL_STATE_COUNT);	165 DCHECK(state < PHYSICAL_WEB_INITIAL_STATE_COUNT);

166 UMA_HISTOGRAM_ENUMERATION("PhysicalWeb.InitialState.IosChrome", state,	166 UMA_HISTOGRAM_EXACT_LINEAR(

167 PHYSICAL_WEB_INITIAL_STATE_COUNT);	167 "PhysicalWeb.InitialState.IosChrome", state,

	168 static_cast<int>(PHYSICAL_WEB_INITIAL_STATE_COUNT));
	Alexei Svitkine (slow) 2017/05/31 20:22:24 Can this use PhysicalWebInitialState instead? Sinc Can this use PhysicalWebInitialState instead? Since there is an enum for it. wychen 2017/07/14 23:18:44 Used PhysicalWebInitialStateIosChrome. Show quoted text On 2017/05/31 20:22:24, Alexei Svitkine (slow) wrote: > Can this use PhysicalWebInitialState instead? Since there is an enum for it. Used PhysicalWebInitialStateIosChrome.
168 }	169 }

169	170

170 @end	171 @end

OLD	NEW