Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(777)

Unified Diff: content/browser/gpu/gpu_process_host.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)
Patch Set: nocompile test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/gpu/gpu_process_host.cc
diff --git a/content/browser/gpu/gpu_process_host.cc b/content/browser/gpu/gpu_process_host.cc
index 172a84bbaa20bc9ef073b90b584ca15d8b3ebd56..39eedfc8dc9a412e562fef378ab90bb3087ac40d 100644
--- a/content/browser/gpu/gpu_process_host.cc
+++ b/content/browser/gpu/gpu_process_host.cc
@@ -548,7 +548,7 @@ GpuProcessHost::~GpuProcessHost() {
// Windows always returns PROCESS_CRASHED on abnormal termination, as it
// doesn't have a way to distinguish the two.
UMA_HISTOGRAM_ENUMERATION("GPU.GPUProcessExitCode",
- exit_code,
+ static_cast<ResultCode>(exit_code),
RESULT_CODE_LAST_CODE);
}
@@ -1114,9 +1114,10 @@ void GpuProcessHost::RecordProcessCrash() {
// options).
if (process_launched_ && kind_ == GPU_PROCESS_KIND_SANDBOXED) {
if (swiftshader_rendering_) {
- UMA_HISTOGRAM_ENUMERATION("GPU.SwiftShaderLifetimeEvents",
- DIED_FIRST_TIME + swiftshader_crash_count_,
- GPU_PROCESS_LIFETIME_EVENT_MAX);
+ UMA_HISTOGRAM_EXACT_LINEAR(
+ "GPU.SwiftShaderLifetimeEvents",
+ DIED_FIRST_TIME + swiftshader_crash_count_,
+ static_cast<int>(GPU_PROCESS_LIFETIME_EVENT_MAX));
if (++swiftshader_crash_count_ >= kGpuMaxCrashCount &&
!disable_crash_limit) {
@@ -1125,10 +1126,11 @@ void GpuProcessHost::RecordProcessCrash() {
}
} else {
++gpu_crash_count_;
- UMA_HISTOGRAM_ENUMERATION("GPU.GPUProcessLifetimeEvents",
- std::min(DIED_FIRST_TIME + gpu_crash_count_,
- GPU_PROCESS_LIFETIME_EVENT_MAX - 1),
- GPU_PROCESS_LIFETIME_EVENT_MAX);
+ UMA_HISTOGRAM_EXACT_LINEAR(
+ "GPU.GPUProcessLifetimeEvents",
+ std::min(DIED_FIRST_TIME + gpu_crash_count_,
+ GPU_PROCESS_LIFETIME_EVENT_MAX - 1),
+ static_cast<int>(GPU_PROCESS_LIFETIME_EVENT_MAX));
// Allow about 1 GPU crash per hour to be removed from the crash count,
// so very occasional crashes won't eventually add up and prevent the

Powered by Google App Engine
This is Rietveld 408576698