Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

components/sync/driver/frontend_data_type_controller.cc

Index: components/sync/driver/frontend_data_type_controller.cc
diff --git a/components/sync/driver/frontend_data_type_controller.cc b/components/sync/driver/frontend_data_type_controller.cc
index 4098642131a2cdc36a4083776293ff88f2263c3e..1bf2c1808f320686d3ac28306f9322ff21fe63f1 100644
--- a/components/sync/driver/frontend_data_type_controller.cc
+++ b/components/sync/driver/frontend_data_type_controller.cc
@@ -238,8 +238,10 @@ void FrontendDataTypeController::RecordAssociationTime(base::TimeDelta time) {
 
 void FrontendDataTypeController::RecordStartFailure(ConfigureResult result) {
   DCHECK(CalledOnValidThread());
+  // TODO(wychen): enum uma should be strongly typed. crbug.com/661401

[Alexei Svitkine (slow), 2017/05/31 20:22:24]

Can't all of these sync ones just use the ModelType enum?

https://cs.chromium.org/chromium/src/components/sync/base/model_type.h?rcl=2f...

[wychen, 2017/07/14 23:18:44]

It takes a much larger CL to do the types correctly.
There's a lookup table for it, and directly using ModelType would break backward
compatibility.

https://cs.chromium.org/chromium/src/components/sync/syncable/model_type.cc?l...

   UMA_HISTOGRAM_ENUMERATION("Sync.DataTypeStartFailures",
-                            ModelTypeToHistogramInt(type()), MODEL_TYPE_COUNT);
+                            ModelTypeToHistogramInt(type()),
+                            static_cast<int>(MODEL_TYPE_COUNT));
 #define PER_DATA_TYPE_MACRO(type_str)                                    \
   UMA_HISTOGRAM_ENUMERATION("Sync." type_str "ConfigureFailure", result, \
                             MAX_CONFIGURE_RESULT);