Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: components/sync/driver/model_type_controller.cc

Issue 2886933003: Use stricter type checking in UMA_HISTOGRAM_ENUMERATION (Closed)
Patch Set: nocompile test Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/model_type_controller.cc
diff --git a/components/sync/driver/model_type_controller.cc b/components/sync/driver/model_type_controller.cc
index 8e98059415eaecb64f5cac21c0e69bfda79a9217..15dd615054efe519b923294b52ac6aeaba0d95cf 100644
--- a/components/sync/driver/model_type_controller.cc
+++ b/components/sync/driver/model_type_controller.cc
@@ -39,9 +39,10 @@ void ReportError(ModelType model_type,
scoped_refptr<base::SingleThreadTaskRunner> ui_thread,
const ModelErrorHandler& error_handler,
const ModelError& error) {
+ // TODO(wychen): enum uma should be strongly typed. crbug.com/661401
UMA_HISTOGRAM_ENUMERATION("Sync.DataTypeRunFailures",
ModelTypeToHistogramInt(model_type),
- MODEL_TYPE_COUNT);
+ static_cast<int>(MODEL_TYPE_COUNT));
ui_thread->PostTask(error.location(), base::Bind(error_handler, error));
}
@@ -245,8 +246,10 @@ void ModelTypeController::ReportModelError(const ModelError& error) {
void ModelTypeController::RecordStartFailure(ConfigureResult result) const {
DCHECK(CalledOnValidThread());
+ // TODO(wychen): enum uma should be strongly typed. crbug.com/661401
UMA_HISTOGRAM_ENUMERATION("Sync.DataTypeStartFailures",
- ModelTypeToHistogramInt(type()), MODEL_TYPE_COUNT);
+ ModelTypeToHistogramInt(type()),
+ static_cast<int>(MODEL_TYPE_COUNT));
#define PER_DATA_TYPE_MACRO(type_str) \
UMA_HISTOGRAM_ENUMERATION("Sync." type_str "ConfigureFailure", result, \
MAX_CONFIGURE_RESULT);

Powered by Google App Engine
This is Rietveld 408576698