Use stricter type checking in UMA_HISTOGRAM_ENUMERATION

components/sync/driver/frontend_data_type_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/sync/driver/frontend_data_type_controller.h"
 
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "components/sync/base/data_type_histogram.h"
@@ skipping 220 matching lines @@
 void FrontendDataTypeController::RecordAssociationTime(base::TimeDelta time) {
   DCHECK(CalledOnValidThread());
 #define PER_DATA_TYPE_MACRO(type_str) \
   UMA_HISTOGRAM_TIMES("Sync." type_str "AssociationTime", time);
   SYNC_DATA_TYPE_HISTOGRAM(type());
 #undef PER_DATA_TYPE_MACRO
 }
 
 void FrontendDataTypeController::RecordStartFailure(ConfigureResult result) {
   DCHECK(CalledOnValidThread());
+  // TODO(wychen): enum uma should be strongly typed. crbug.com/661401

[Alexei Svitkine (slow), 2017/05/31 20:22:24]

Can't all of these sync ones just use the ModelType enum?

https://cs.chromium.org/chromium/src/components/sync/base/model_type.h?rcl=2f...

[wychen, 2017/07/14 23:18:44]

It takes a much larger CL to do the types correctly.
There's a lookup table for it, and directly using ModelType would break backward
compatibility.

https://cs.chromium.org/chromium/src/components/sync/syncable/model_type.cc?l...

   UMA_HISTOGRAM_ENUMERATION("Sync.DataTypeStartFailures",
-                            ModelTypeToHistogramInt(type()), MODEL_TYPE_COUNT);
+                            ModelTypeToHistogramInt(type()),
+                            static_cast<int>(MODEL_TYPE_COUNT));
 #define PER_DATA_TYPE_MACRO(type_str)                                    \
   UMA_HISTOGRAM_ENUMERATION("Sync." type_str "ConfigureFailure", result, \
                             MAX_CONFIGURE_RESULT);
   SYNC_DATA_TYPE_HISTOGRAM(type());
 #undef PER_DATA_TYPE_MACRO
 }
 
 AssociatorInterface* FrontendDataTypeController::model_associator() const {
   return model_associator_.get();
 }
 
 void FrontendDataTypeController::set_model_associator(
     AssociatorInterface* model_associator) {
   model_associator_.reset(model_associator);
 }
 
 ChangeProcessor* FrontendDataTypeController::GetChangeProcessor() const {
   return change_processor_.get();
 }
 
 void FrontendDataTypeController::set_change_processor(
     ChangeProcessor* change_processor) {
   change_processor_.reset(change_processor);
 }
 
 }  // namespace syncer