Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 2886893007: Replace CSSAnimationData::Create(CSSAnimation) with clone method. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 days, 12 hours ago by shend
Modified:
3 days, 12 hours ago
Reviewers:
alancutter
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace CSSAnimationData::Create(CSSAnimation) with clone method. To copy a CSSAnimationData, we use CSSAnimationData::Create(o). However, this interface is inconsistent with many other classes that instead provide a clone method to do the same thing. This patch replaces the Create method with a Clone method to be consistent. BUG=628043 Review-Url: https://codereview.chromium.org/2886893007 Cr-Commit-Position: refs/heads/master@{#473049} Committed: https://chromium.googlesource.com/chromium/src/+/6ba38ebb11493db01fdd044a9a7cefbc332bc31e

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 22 (16 generated)
shend
Hi Alan, PTAL
4 days, 12 hours ago (2017-05-18 03:09:22 UTC) #3
alancutter
lgtm
4 days, 9 hours ago (2017-05-18 05:34:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886893007/1
4 days, 4 hours ago (2017-05-18 10:32:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/440954)
4 days, 4 hours ago (2017-05-18 10:40:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886893007/20001
3 days, 13 hours ago (2017-05-19 01:49:26 UTC) #19
commit-bot: I haz the power
3 days, 12 hours ago (2017-05-19 02:57:50 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6ba38ebb11493db01fdd044a9a7c...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 650457f06