Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2886893007: Replace CSSAnimationData::Create(CSSAnimation) with clone method. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace CSSAnimationData::Create(CSSAnimation) with clone method. To copy a CSSAnimationData, we use CSSAnimationData::Create(o). However, this interface is inconsistent with many other classes that instead provide a clone method to do the same thing. This patch replaces the Create method with a Clone method to be consistent. BUG=628043 Review-Url: https://codereview.chromium.org/2886893007 Cr-Commit-Position: refs/heads/master@{#473049} Committed: https://chromium.googlesource.com/chromium/src/+/6ba38ebb11493db01fdd044a9a7cefbc332bc31e

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M third_party/WebKit/Source/core/animation/css/CSSAnimationData.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/style/StyleRareNonInheritedData.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 22 (16 generated)
shend
Hi Alan, PTAL
3 years, 7 months ago (2017-05-18 03:09:22 UTC) #3
alancutter (OOO until 2018)
lgtm
3 years, 7 months ago (2017-05-18 05:34:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886893007/1
3 years, 7 months ago (2017-05-18 10:32:57 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/440954)
3 years, 7 months ago (2017-05-18 10:40:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886893007/20001
3 years, 7 months ago (2017-05-19 01:49:26 UTC) #19
commit-bot: I haz the power
3 years, 7 months ago (2017-05-19 02:57:50 UTC) #22
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6ba38ebb11493db01fdd044a9a7c...

Powered by Google App Engine
This is Rietveld 408576698