Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2886893003: Revert of Remove webrtc_rendering_stats TBMv1 metrics (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of Remove webrtc_rendering_stats TBMv1 metrics (patchset #2 id:20001 of https://codereview.chromium.org/2890443002/ ) Reason for revert: Blocking roll. This can only be landed after https://chromium-review.googlesource.com/c/506017/ is landed. Original issue's description: > Remove webrtc_rendering_stats TBMv1 metrics > > These metrics are already converted to TBMv2 version: > https://github.com/catapult-project/catapult/blob/master/tracing/tracing/metrics/webrtc/webrtc_rendering_metric.html > > TBR=tdresser@chromium.org > > Review-Url: https://codereview.chromium.org/2890443002 > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f48086407653878212fe819a0ad0531132a4be98 TBR=ehmaldonado@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2886893003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/dab2aa44c6cdeb08d15cb32cb169edb2a41bd662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+774 lines, -1 line) Patch
A telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats.py View 1 chunk +366 lines, -0 lines 0 comments Download
A telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats_unittest.py View 1 chunk +271 lines, -0 lines 0 comments Download
A telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py View 1 chunk +133 lines, -0 lines 0 comments Download
M telemetry/telemetry/web_perf/timeline_based_measurement.py View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
nednguyen
Created Revert of Remove webrtc_rendering_stats TBMv1 metrics
3 years, 7 months ago (2017-05-17 00:01:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886893003/1
3 years, 7 months ago (2017-05-17 00:01:32 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 00:01:39 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698