Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2890443002: Remove webrtc_rendering_stats TBMv1 metrics (Closed)

Created:
3 years, 7 months ago by nednguyen
Modified:
3 years, 7 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Update ref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -774 lines) Patch
D telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats.py View 1 chunk +0 lines, -366 lines 0 comments Download
D telemetry/telemetry/web_perf/metrics/webrtc_rendering_stats_unittest.py View 1 chunk +0 lines, -271 lines 0 comments Download
D telemetry/telemetry/web_perf/metrics/webrtc_rendering_timeline.py View 1 chunk +0 lines, -133 lines 0 comments Download
M telemetry/telemetry/web_perf/timeline_based_measurement.py View 1 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
nednguyen
3 years, 7 months ago (2017-05-16 13:07:43 UTC) #2
ehmaldonado_chromium
On 2017/05/16 13:07:43, nednguyen wrote: lgtm
3 years, 7 months ago (2017-05-16 13:29:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890443002/20001
3 years, 7 months ago (2017-05-16 13:34:31 UTC) #10
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-16 13:34:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890443002/20001
3 years, 7 months ago (2017-05-16 15:02:51 UTC) #14
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 7 months ago (2017-05-16 15:02:52 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2890443002/20001
3 years, 7 months ago (2017-05-16 15:03:18 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f48086407653878212fe819a0ad0531132a4be98
3 years, 7 months ago (2017-05-16 15:27:14 UTC) #22
nednguyen
3 years, 7 months ago (2017-05-17 00:01:28 UTC) #23
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2886893003/ by nednguyen@google.com.

The reason for reverting is: Blocking roll. This can only be landed after
https://chromium-review.googlesource.com/c/506017/ is landed..

Powered by Google App Engine
This is Rietveld 408576698