[kernel] Streaming ScopeBuilder

[kernel] Streaming ScopeBuilder

The old ScopeBuilder is replaced with StreamingScopeBuilder
that does not use the Ast.

R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/76336b225f301dd44c6ff622de75ca4f1e26534f

[jensj, 2017-05-18 10:54:19]

jensj@google.com changed reviewers:
+ kmillikin@google.com

[Kevin Millikin (Google), 2017-06-12 08:25:14]

LGTM.

https://codereview.chromium.org/2886873008/diff/1/pkg/kernel/binary.md
File pkg/kernel/binary.md (right):

https://codereview.chromium.org/2886873008/diff/1/pkg/kernel/binary.md#newcod...
pkg/kernel/binary.md:225: UInt parentPosition; // Byte offset in the binary for
the parent class, or 0 if parent is not a class.
Put the comment before the field and wrap it to 80 characters (also below).

https://codereview.chromium.org/2886873008/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2886873008/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:248: if (node != NULL) {
We know node != NULL.  We can also move all this code into `if
(function().kernel_function() != NULL)` above.

https://codereview.chromium.org/2886873008/diff/1/runtime/vm/parser.cc#newcod...
runtime/vm/parser.cc:250: while (true) {
The nested loops make this seem complicated.  Isn't it just (1) loop up
parent_function until we come to a function without a parent_function, then (2)
get either the Kernel parent or parent's parent?

[jensj, 2017-06-12 08:28:18]

The changes in parser.cc is replaced in 2901533002.

[jensj, 2017-06-13 09:39:38]

Description was changed from

==========
[kernel] Streaming ScopeBuilder

The old ScopeBuilder is replaced with StreamingScopeBuilder
that does not use the Ast.
==========

to

==========
[kernel] Streaming ScopeBuilder

The old ScopeBuilder is replaced with StreamingScopeBuilder
that does not use the Ast.

R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/76336b225f301dd44c6ff622de75ca4f1e26534f
==========

[jensj, 2017-06-13 09:39:39]

Committed patchset #2 (id:20001) manually as
76336b225f301dd44c6ff622de75ca4f1e26534f (presubmit successful).

[jensj, 2017-06-13 09:41:02]

Thanks for the review. I've updated the binary.md file, ignored parser.cc
comments because it's updated with the next land, rebased and attempted a land.

https://codereview.chromium.org/2886873008/diff/1/pkg/kernel/binary.md
File pkg/kernel/binary.md (right):

https://codereview.chromium.org/2886873008/diff/1/pkg/kernel/binary.md#newcod...
pkg/kernel/binary.md:225: UInt parentPosition; // Byte offset in the binary for
the parent class, or 0 if parent is not a class.
On 2017/06/12 08:25:14, Kevin Millikin (Google) wrote:
> Put the comment before the field and wrap it to 80 characters (also below).

Done.