[kernel] Streaming ScopeBuilder

pkg/kernel/binary.md

 This file describes the binary format of Dart Kernel.
 
 Notation
 --------
 Bitmasks are described with the syntax:
 ```scala
     Byte flags (flag1, flag2, ..., flagN)
 ```
 where 'flag<N>' is the N-th least significant bit,
 (so flag1 is the least significant bit).
@@ skipping 204 matching lines @@
 }
 
 abstract type Member extends Node {}
 
 type Field extends Member {
   Byte tag = 4;
   CanonicalNameReference canonicalName;
   FileOffset fileOffset;
   FileOffset fileEndOffset;
   Byte flags (isFinal, isConst, isStatic);
+  UInt parentPosition; // Byte offset in the binary for the parent class, or 0 if parent is not a class.

[Kevin Millikin (Google), 2017/06/12 08:25:14]

Put the comment before the field and wrap it to 80 characters (also below).

[jensj, 2017/06/13 09:41:02]

Done.

   Name name;
   // An absolute path URI to the .dart file from which the field was created.
   UriReference fileUri;
   List<Expression> annotations;
   DartType type;
   Option<Expression> initializer;
 }
 
 type Constructor extends Member {
   Byte tag = 5;
   CanonicalNameReference canonicalName;
   FileOffset fileOffset;
   FileOffset fileEndOffset;
   Byte flags (isConst, isExternal);
+  UInt parentPosition; // Byte offset in the binary for the parent class.
   Name name;
   List<Expression> annotations;
   FunctionNode function;
   List<Initializer> initializers;
 }
 
 /*
 enum ProcedureKind {
   Method,
   Getter,
   Setter,
   Operator,
   Factory,
 }
 */
 
 type Procedure extends Member {
   Byte tag = 6;
   CanonicalNameReference canonicalName;
   FileOffset fileOffset;
   FileOffset fileEndOffset;
   Byte kind; // Index into the ProcedureKind enum above.
   Byte flags (isStatic, isAbstract, isExternal, isConst);
+  UInt parentPosition; // Byte offset in the binary for the parent class, or 0 if parent is not a class.
   Name name;
   // An absolute path URI to the .dart file from which the class was created.
   UriReference fileUri;
   List<Expression> annotations;
   // Can only be absent if abstract, but tag is there anyway.
   Option<FunctionNode> function;
 }
 
 abstract type Initializer extends Node {}
 
@@ skipping 28 matching lines @@
 enum AsyncMarker {
   Sync,
   SyncStar,
   Async,
   AsyncStar,
   SyncYielding
 }
 */
 
 type FunctionNode {
-  // Note: there is no tag on FunctionNode.
+  Byte tag = 3;
   FileOffset fileOffset;
   FileOffset fileEndOffset;
   Byte asyncMarker; // Index into AsyncMarker above.
   Byte dartAsyncMarker; // Index into AsyncMarker above.
   List<TypeParameter> typeParameters;
   UInt requiredParameterCount;
   List<VariableDeclaration> positionalParameters;
   List<VariableDeclaration> namedParameters;
   DartType returnType;
   Option<Statement> body;
@@ skipping 24 matching lines @@
 
 abstract type Expression extends Node {}
 
 type InvalidExpression extends Expression {
   Byte tag = 19;
 }
 
 type VariableGet extends Expression {
   Byte tag = 20;
   FileOffset fileOffset;
-  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration.
+  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration (without tag).
   VariableReference variable;
 }
 
 type SpecializedVariableGet extends Expression {
   Byte tag = 128 + N; // Where 0 <= N < 8.
   // Equivalent to a VariableGet with index N.
   FileOffset fileOffset;
-  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration.
+  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration (without tag).
 }
 
 type VariableSet extends Expression {
   Byte tag = 21;
   FileOffset fileOffset;
-  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration.
+  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration (without tag).
   VariableReference variable;
   Expression value;
 }
 
 type SpecializedVariableSet extends Expression {
   Byte tag = 136 + N; // Where 0 <= N < 8.
   FileOffset fileOffset;
-  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration.
+  UInt variableDeclarationPosition; // Byte offset in the binary for the variable declaration (without tag).
   Expression value;
   // Equivalent to VariableSet with index N.
 }
 
 type PropertyGet extends Expression {
   Byte tag = 22;
   FileOffset fileOffset;
   Expression receiver;
   Name name;
   MemberReference interfaceTarget; // May be NullReference.
@@ skipping 584 matching lines @@
   Byte tag = 88;
 }
 
 type TypeParameter {
   // Note: there is no tag on TypeParameter
   StringReference name; // Cosmetic, may be empty, not unique.
   DartType bound; // 'dynamic' if no explicit bound was given.
 }
 
 ```