Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Unified Diff: pkg/kernel/lib/binary/ast_from_binary.dart

Issue 2886873008: [kernel] Streaming ScopeBuilder (Closed)
Patch Set: Addressed (some) comments; rebased. Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/lib/binary/ast_to_binary.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/kernel/lib/binary/ast_from_binary.dart
diff --git a/pkg/kernel/lib/binary/ast_from_binary.dart b/pkg/kernel/lib/binary/ast_from_binary.dart
index a86294d01f2fffedea04bcdd0753debe1494a31e..95a4ea30dd7b89a45b56708dc88c752b801fe21b 100644
--- a/pkg/kernel/lib/binary/ast_from_binary.dart
+++ b/pkg/kernel/lib/binary/ast_from_binary.dart
@@ -485,6 +485,7 @@ class BinaryBuilder {
int fileOffset = readOffset();
int fileEndOffset = readOffset();
int flags = readByte();
+ readUInt(); // parent class binary offset.
var name = readName();
var fileUri = readUriReference();
var annotations = readAnnotationList(node);
@@ -521,6 +522,7 @@ class BinaryBuilder {
var fileOffset = readOffset();
var fileEndOffset = readOffset();
var flags = readByte();
+ readUInt(); // parent class binary offset.
var name = readName();
var annotations = readAnnotationList(node);
debugPath.add(node.name?.name ?? 'constructor');
@@ -558,6 +560,7 @@ class BinaryBuilder {
int kindIndex = readByte();
var kind = ProcedureKind.values[kindIndex];
var flags = readByte();
+ readUInt(); // parent class binary offset.
var name = readName();
var fileUri = readUriReference();
var annotations = readAnnotationList(node);
@@ -606,6 +609,8 @@ class BinaryBuilder {
}
FunctionNode readFunctionNode() {
+ int tag = readByte();
+ assert(tag == Tag.FunctionNode);
int offset = readOffset();
int endOffset = readOffset();
AsyncMarker asyncMarker = AsyncMarker.values[readByte()];
« no previous file with comments | « pkg/kernel/lib/ast.dart ('k') | pkg/kernel/lib/binary/ast_to_binary.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698