Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2886613002:
Prune ComputeVisibleSelectionInDOMTreeDeprecated from WebViewImpl::SelectionBounds (Closed)
DescriptionPrune ComputeVisibleSelectionInDOMTreeDeprecated from WebViewImpl::SelectionBounds
This patch prunes a call site of the deprecated function, which is safe because
layout is already clean there.
BUG=698633
TEST=n/a; no behavioral changes
Review-Url: https://codereview.chromium.org/2886613002
Cr-Commit-Position: refs/heads/master@{#472006}
Committed: https://chromium.googlesource.com/chromium/src/+/35c9b9467e191901889c235cfc438fd32a99edf6
Patch Set 1 #
Messages
Total messages: 22 (18 generated)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from WebViewImpl::SelectionBounds BUG= ========== to ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from WebViewImpl::SelectionBounds This patch prunes a call site of the deprecated function, which is safe because layout is already clean there. BUG=698633 TEST=n/a; no behavioral changes ==========
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
xiaochengh@chromium.org changed reviewers: + tkent@chromium.org
PTAL.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaochengh@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494905747675520, "parent_rev":
"80ecb98035a6654fff02e86877be39f51fcc3d54", "commit_rev":
"e81f3900f695a3ef8adc355cc89a3f117d5fac14"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494905747675520, "parent_rev":
"f6b532b1dd5414119e5914988ceb75e2211f91da", "commit_rev":
"35c9b9467e191901889c235cfc438fd32a99edf6"}
Message was sent while issue was closed.
Description was changed from ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from WebViewImpl::SelectionBounds This patch prunes a call site of the deprecated function, which is safe because layout is already clean there. BUG=698633 TEST=n/a; no behavioral changes ========== to ========== Prune ComputeVisibleSelectionInDOMTreeDeprecated from WebViewImpl::SelectionBounds This patch prunes a call site of the deprecated function, which is safe because layout is already clean there. BUG=698633 TEST=n/a; no behavioral changes Review-Url: https://codereview.chromium.org/2886613002 Cr-Commit-Position: refs/heads/master@{#472006} Committed: https://chromium.googlesource.com/chromium/src/+/35c9b9467e191901889c235cfc43... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/35c9b9467e191901889c235cfc43... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
