Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2375)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2886613002: Prune ComputeVisibleSelectionInDOMTreeDeprecated from WebViewImpl::SelectionBounds (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 97202d478f8967ea0538a41088deb35647663e78..8bcc3892a1b8a7232cad84ffc6c2c98d508ee595 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -2394,11 +2394,11 @@ bool WebViewImpl::SelectionBounds(WebRect& anchor, WebRect& focus) const {
DocumentLifecycle::DisallowTransitionScope disallow_transition(
local_frame->GetDocument()->Lifecycle());
- if (selection.ComputeVisibleSelectionInDOMTreeDeprecated().IsCaret()) {
+ if (selection.ComputeVisibleSelectionInDOMTree().IsCaret()) {
anchor = focus = selection.AbsoluteCaretBounds();
} else {
const EphemeralRange selected_range =
- selection.ComputeVisibleSelectionInDOMTreeDeprecated()
+ selection.ComputeVisibleSelectionInDOMTree()
.ToNormalizedEphemeralRange();
if (selected_range.IsNull())
return false;
@@ -2411,7 +2411,7 @@ bool WebViewImpl::SelectionBounds(WebRect& anchor, WebRect& focus) const {
anchor = local_frame->View()->ContentsToViewport(anchor);
focus = local_frame->View()->ContentsToViewport(focus);
- if (!selection.ComputeVisibleSelectionInDOMTreeDeprecated().IsBaseFirst())
+ if (!selection.ComputeVisibleSelectionInDOMTree().IsBaseFirst())
std::swap(anchor, focus);
return true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698