Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2886583002: Merge to 3071 "[DevTools] Fix telemetry flakiness based on target type" (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
pfeldman
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge to 3071 "[DevTools] Fix telemetry flakiness based on target type" For some unknown reason, crrev.com/468815 caused multiple telemetry tests to timeout. This patch partially reverts that revision, applying another fix to original bug by re-requesting target type on demand. BUG=718952, 717003 Review-Url: https://codereview.chromium.org/2873393002 Cr-Commit-Position: refs/heads/master@{#471102} (cherry picked from commit 8e75b1bc9944bfe1a4a1a006e212418243e96abd) TBR=pfeldman Review-Url: https://codereview.chromium.org/2886583002 . Cr-Commit-Position: refs/branch-heads/3071@{#571} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/cadfb3115e3b20f61e342523a12325a94ded2786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dgozman
3 years, 7 months ago (2017-05-15 22:38:59 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cadfb3115e3b20f61e342523a12325a94ded2786.

Powered by Google App Engine
This is Rietveld 408576698