Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 2873393002: [DevTools] Fix telemetry flakiness based on target type (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix telemetry flakiness based on target type For some unknown reason, crrev.com/468815 caused multiple telemetry tests to timeout. This patch partially reverts that revision, applying another fix to original bug by re-requesting target type on demand. BUG=718952, 717003 Review-Url: https://codereview.chromium.org/2873393002 Cr-Commit-Position: refs/heads/master@{#471102} Committed: https://chromium.googlesource.com/chromium/src/+/8e75b1bc9944bfe1a4a1a006e212418243e96abd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 2 chunks +14 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
richard.townsend
Patchset #1 seems to resolve both of the bugs, lgtm.
3 years, 7 months ago (2017-05-10 18:00:56 UTC) #4
dgozman
Pavel, could you please take a look?
3 years, 7 months ago (2017-05-10 20:51:49 UTC) #8
pfeldman
lgtm
3 years, 7 months ago (2017-05-11 20:43:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2873393002/1
3 years, 7 months ago (2017-05-11 20:44:42 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 22:52:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8e75b1bc9944bfe1a4a1a006e212...

Powered by Google App Engine
This is Rietveld 408576698