[ObjC ARC] Converts ios/web:earl_grey_test_support to ARC.

[ObjC ARC] Converts ios/web:earl_grey_test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2886573002
Cr-Commit-Position: refs/heads/master@{#476713}
Committed: https://chromium.googlesource.com/chromium/src/+/7a047d2cebdea7a02b432bafc6d2b6c26f50a0f3

[baxley, 2017-05-15 21:49:57]

The CQ bit was checked by baxley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-15 21:50:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-15 23:50:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-15 23:50:02]

Dry run: This issue passed the CQ dry run.

[baxley, 2017-05-16 20:12:47]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org, stkhapugin@chromium.org

[baxley, 2017-05-16 20:12:48]

Including stkhapugin@, in case there are ways more consistent with our code-base
than __autoreleasing (or if it is just wrong).

Thanks!

https://codereview.chromium.org/2886573002/diff/20001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/js_test_util.h (right):

https://codereview.chromium.org/2886573002/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/js_test_util.h:26: NSError* __autoreleasing*
out_error);
This is one of the more interesting things I did. Let me know if you have
thoughts/concerns.

[Eugene But (OOO till 7-30), 2017-05-16 22:39:37]

lgtm

https://codereview.chromium.org/2886573002/diff/20001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/web_view_matchers.mm (right):

https://codereview.chromium.org/2886573002/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/web_view_matchers.mm:76: if (task_error) {
Do we even need this if-else? Should we simply assign the values?

[stkhapugin, 2017-05-30 13:21:38]

lgtm

https://codereview.chromium.org/2886573002/diff/20001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/js_test_util.h (right):

https://codereview.chromium.org/2886573002/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/js_test_util.h:26: NSError* __autoreleasing*
out_error);
On 2017/05/16 20:12:48, baxley wrote:
> This is one of the more interesting things I did. Let me know if you have
> thoughts/concerns.

This looks right to me.

[baxley, 2017-06-02 15:38:27]

The CQ bit was checked by baxley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-02 15:38:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[baxley, 2017-06-02 15:39:38]

Comments addressed. Running through dry run and EG trybot before landing.
Thanks!

https://codereview.chromium.org/2886573002/diff/20001/ios/web/public/test/ear...
File ios/web/public/test/earl_grey/web_view_matchers.mm (right):

https://codereview.chromium.org/2886573002/diff/20001/ios/web/public/test/ear...
ios/web/public/test/earl_grey/web_view_matchers.mm:76: if (task_error) {
On 2017/05/16 22:39:37, Eugene But wrote:
> Do we even need this if-else? Should we simply assign the values?

Done.

[commit-bot: I haz the power, 2017-06-02 17:19:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-02 17:19:09]

Dry run: This issue passed the CQ dry run.

[baxley, 2017-06-02 17:42:52]

The CQ bit was checked by baxley@chromium.org

[baxley, 2017-06-02 17:42:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
stkhapugin@chromium.org, eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2886573002/#ps40001
(title: "remove unecessary if statement")

[commit-bot: I haz the power, 2017-06-02 17:43:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-02 17:47:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496425372892770,
"parent_rev": "eed40bc79df20716a280b62fb3d1f1f0a40df0a1", "commit_rev":
"7a047d2cebdea7a02b432bafc6d2b6c26f50a0f3"}

[commit-bot: I haz the power, 2017-06-02 17:48:06]

Description was changed from

==========
[ObjC ARC] Converts ios/web:earl_grey_test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/web:earl_grey_test_support to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2886573002
Cr-Commit-Position: refs/heads/master@{#476713}
Committed:
https://chromium.googlesource.com/chromium/src/+/7a047d2cebdea7a02b432bafc6d2...
==========

[commit-bot: I haz the power, 2017-06-02 17:48:08]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/7a047d2cebdea7a02b432bafc6d2...