Add check for that reader is not null in GetPostData

Add check for that reader is not null in GetPostData.

This is necessary as the reader maybe not be an UploadBytesElementReader, but other subclasses of UploadElementReader e.g. UploadBlobElementReader.

BUG=723983
Review-Url: https://codereview.chromium.org/2886403002
Cr-Commit-Position: refs/heads/master@{#472990}
Committed: https://chromium.googlesource.com/chromium/src/+/1c72320950b6ac44b11399af2c07691e354921b2

[irisu, 2017-05-18 07:17:53]

The CQ bit was checked by irisu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 07:18:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 08:47:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 08:47:41]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[irisu, 2017-05-18 13:08:15]

The CQ bit was checked by irisu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 13:08:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 13:41:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 13:41:07]

Dry run: This issue passed the CQ dry run.

[irisu, 2017-05-18 13:59:20]

Description was changed from

==========
Add check for that reader is not null in GetPostData

BUG=723983
==========

to

==========
Add check for that reader is not null in GetPostData.

This is necessary as the reader maybe not be an UploadBytesElementReader, but
other subclasses of UploadElementReader e.g. UploadBlobElementReader.

BUG=723983
==========

[irisu, 2017-05-18 13:59:21]

irisu@chromium.org changed reviewers:
+ alexclarke@chromium.org

[irisu, 2017-05-18 14:02:28]

An alternative is to use UploadElementReader's Read method [1], but it may not
be necessary to get the bytes from any other reader type. It would also be
considerably more complex, since the Read method can be asynchronous, and would
need to be handled synchronously.

[1]
https://cs.chromium.org/chromium/src/net/base/upload_element_reader.h?rcl=efe...

[alex clarke (OOO till 29th), 2017-05-18 15:23:22]

LGTM

[irisu, 2017-05-19 00:13:36]

The CQ bit was checked by irisu@chromium.org

[commit-bot: I haz the power, 2017-05-19 00:15:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 00:23:52]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1495152816150920, "parent_rev":
"b3cad27b421b2aa9f6b0a89c80238480ba14023e", "commit_rev":
"1c72320950b6ac44b11399af2c07691e354921b2"}

[commit-bot: I haz the power, 2017-05-19 00:24:07]

Description was changed from

==========
Add check for that reader is not null in GetPostData.

This is necessary as the reader maybe not be an UploadBytesElementReader, but
other subclasses of UploadElementReader e.g. UploadBlobElementReader.

BUG=723983
==========

to

==========
Add check for that reader is not null in GetPostData.

This is necessary as the reader maybe not be an UploadBytesElementReader, but
other subclasses of UploadElementReader e.g. UploadBlobElementReader.

BUG=723983

Review-Url: https://codereview.chromium.org/2886403002
Cr-Commit-Position: refs/heads/master@{#472990}
Committed:
https://chromium.googlesource.com/chromium/src/+/1c72320950b6ac44b11399af2c07...
==========

[commit-bot: I haz the power, 2017-05-19 00:24:08]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1c72320950b6ac44b11399af2c07...