Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: headless/public/util/generic_url_request_job.cc

Issue 2886403002: Add check for that reader is not null in GetPostData (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "headless/public/util/generic_url_request_job.h" 5 #include "headless/public/util/generic_url_request_job.h"
6 6
7 #include <string.h> 7 #include <string.h>
8 #include <algorithm> 8 #include <algorithm>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 254 matching lines...) Expand 10 before | Expand all | Expand 10 after
265 const net::UploadDataStream* stream = request_->get_upload(); 265 const net::UploadDataStream* stream = request_->get_upload();
266 if (!stream->GetElementReaders()) 266 if (!stream->GetElementReaders())
267 return ""; 267 return "";
268 268
269 if (stream->GetElementReaders()->size() == 0) 269 if (stream->GetElementReaders()->size() == 0)
270 return ""; 270 return "";
271 271
272 DCHECK_EQ(1u, stream->GetElementReaders()->size()); 272 DCHECK_EQ(1u, stream->GetElementReaders()->size());
273 const net::UploadBytesElementReader* reader = 273 const net::UploadBytesElementReader* reader =
274 (*stream->GetElementReaders())[0]->AsBytesReader(); 274 (*stream->GetElementReaders())[0]->AsBytesReader();
275 if (!reader)
276 return "";
275 return std::string(reader->bytes(), reader->length()); 277 return std::string(reader->bytes(), reader->length());
276 } 278 }
277 279
278 const Request* GenericURLRequestJob::GetRequest() const { 280 const Request* GenericURLRequestJob::GetRequest() const {
279 return this; 281 return this;
280 } 282 }
281 283
282 void GenericURLRequestJob::AllowRequest() { 284 void GenericURLRequestJob::AllowRequest() {
283 if (!origin_task_runner_->RunsTasksOnCurrentThread()) { 285 if (!origin_task_runner_->RunsTasksOnCurrentThread()) {
284 origin_task_runner_->PostTask( 286 origin_task_runner_->PostTask(
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
334 } 336 }
335 337
336 mock_response_ = std::move(mock_response); 338 mock_response_ = std::move(mock_response);
337 339
338 OnFetchCompleteExtractHeaders(request_->url(), 340 OnFetchCompleteExtractHeaders(request_->url(),
339 mock_response_->response_data.data(), 341 mock_response_->response_data.data(),
340 mock_response_->response_data.size()); 342 mock_response_->response_data.size());
341 } 343 }
342 344
343 } // namespace headless 345 } // namespace headless
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698