Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2886363003: Remove unused handwritten StyleInheritedData in ComputedStyle. (Closed)

Created:
3 years, 7 months ago by shend
Modified:
3 years, 7 months ago
Reviewers:
meade_UTC10
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused handwritten StyleInheritedData in ComputedStyle. In an earlier patch [1], we generated StyleInheritedData in ComputedStyleBase. Unfortunately, we did not remove the corresponding handwritten StyleInheritedData in ComputedStyle. This follow up patch removes the unused handwritten nested class. [1] https://codereview.chromium.org/2840503002 BUG=628043 Review-Url: https://codereview.chromium.org/2886363003 Cr-Commit-Position: refs/heads/master@{#472752} Committed: https://chromium.googlesource.com/chromium/src/+/e82ba08821352cde479db52f3b9379ea23d2b54b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -44 lines) Patch
M third_party/WebKit/Source/core/style/ComputedStyle.h View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
shend
Hi Eddy, PTAL :)
3 years, 7 months ago (2017-05-18 03:47:03 UTC) #3
meade_UTC10
lgtm lol whoops!
3 years, 7 months ago (2017-05-18 05:54:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2886363003/1
3 years, 7 months ago (2017-05-18 06:59:19 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-18 09:30:14 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e82ba08821352cde479db52f3b93...

Powered by Google App Engine
This is Rietveld 408576698