Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2840503002:
Generate StyleInheritedData in ComputedStyleBase. (Closed)
|
Created:
3 years, 8 months ago by shend Modified:
3 years, 7 months ago CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, blink-reviews-style_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, kinuko+watch, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, rwlbuis, szager+layoutwatch_chromium.org, zoltan1 Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionGenerate StyleInheritedData in ComputedStyleBase.
This patch generates the following fields as part of a group:
- horizontal-border-spacing (short)
- vertical-border-spacing (short)
- line-height (Length)
- font (Font)
- color (Color)
- VisitedLinkColor (Color)
- TextAutoSizingMultiplier (float)
All fields are generated as storage_only in this patch, but future patches
may change that.
Diff of generated files:
https://gist.github.com/darrnshn/28f4f79881e6474913f87257fed006a4/revisions
BUG=628043
Review-Url: https://codereview.chromium.org/2840503002
Cr-Commit-Position: refs/heads/master@{#472598}
Committed: https://chromium.googlesource.com/chromium/src/+/48dacf962778b8fb9c0d8b49921d21c9163ba88c
Patch Set 1 #Patch Set 2 : Rebase #Patch Set 3 : Rebase #Patch Set 4 : Rebase #Patch Set 5 : Rebase #Patch Set 6 : Rebase #Patch Set 7 : Rebase #Patch Set 8 : Rebase #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 49 (40 generated)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
Generate StyleInheritedData in ComputedStyleBase.
This patch generates the following fields as part of a group:
- horizontal-border-spacing ('storage_only' of type short)
- vertical-border-spacing ('storage_only' of type short)
- line-height ('storage-only' of type Length)
- font ('storage_only' of type Font)
- color ('storage_only' of type Color)
- VisitedLinkColor ('storage_only' of type Color)
- TextAutoSizingMultiplier ('storage_only' of type float)
BUG=628043
==========
to
==========
Generate StyleInheritedData in ComputedStyleBase.
This patch generates the following fields as part of a group:
- horizontal-border-spacing ('storage_only' of type short)
- vertical-border-spacing ('storage_only' of type short)
- line-height ('storage-only' of type Length)
- font ('storage_only' of type Font)
- color ('storage_only' of type Color)
- VisitedLinkColor ('storage_only' of type Color)
- TextAutoSizingMultiplier ('storage_only' of type float)
Diff of generated files:
https://gist.github.com/darrnshn/28f4f79881e6474913f87257fed006a4/revisions
BUG=628043
==========
shend@chromium.org changed reviewers: + nainar@chromium.org
Hi Naina, PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
shend@chromium.org changed reviewers: - nainar@chromium.org
On 2017/04/24 at 07:16:14, shend wrote: > Hi Naina, PTAL -nainar, as this patch fails some tests.
Description was changed from
==========
Generate StyleInheritedData in ComputedStyleBase.
This patch generates the following fields as part of a group:
- horizontal-border-spacing ('storage_only' of type short)
- vertical-border-spacing ('storage_only' of type short)
- line-height ('storage-only' of type Length)
- font ('storage_only' of type Font)
- color ('storage_only' of type Color)
- VisitedLinkColor ('storage_only' of type Color)
- TextAutoSizingMultiplier ('storage_only' of type float)
Diff of generated files:
https://gist.github.com/darrnshn/28f4f79881e6474913f87257fed006a4/revisions
BUG=628043
==========
to
==========
Generate StyleInheritedData in ComputedStyleBase.
This patch generates the following fields as part of a group:
- horizontal-border-spacing (short)
- vertical-border-spacing (short)
- line-height (Length)
- font (Font)
- color (Color)
- VisitedLinkColor (Color)
- TextAutoSizingMultiplier (float)
All fields are generated as storage_only in this patch, but future patches
may change that.
Diff of generated files:
https://gist.github.com/darrnshn/28f4f79881e6474913f87257fed006a4/revisions
BUG=628043
==========
Description was changed from ========== Generate StyleInheritedData in ComputedStyleBase. This patch generates the following fields as part of a group: - horizontal-border-spacing (short) - vertical-border-spacing (short) - line-height (Length) - font (Font) - color (Color) - VisitedLinkColor (Color) - TextAutoSizingMultiplier (float) All fields are generated as storage_only in this patch, but future patches may change that. Diff of generated files: https://gist.github.com/darrnshn/28f4f79881e6474913f87257fed006a4/revisions BUG=628043 ========== to ========== Generate StyleInheritedData in ComputedStyleBase. This patch generates the following fields as part of a group: - horizontal-border-spacing (short) - vertical-border-spacing (short) - line-height (Length) - font (Font) - color (Color) - VisitedLinkColor (Color) - TextAutoSizingMultiplier (float) All fields are generated as storage_only in this patch, but future patches may change that. All these fields are inherited. Inherited fields go through a fast path in ComputedStyle::InheritedDataShared, which is currently handwritten. Hence this patch also generates InheritedDataShared so that it will still work when we change where these fields are stored. Diff of generated files: https://gist.github.com/darrnshn/28f4f79881e6474913f87257fed006a4/revisions BUG=628043 ==========
The CQ bit was checked by shend@chromium.org to run a CQ dry run
shend@chromium.org changed reviewers: + nainar@chromium.org
Hi Naina, PTAL
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/27 at 08:03:41, shend wrote: > Hi Naina, PTAL Not exactly sure how InheritedDataShared should behave when we start moving fields around.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Description was changed from ========== Generate StyleInheritedData in ComputedStyleBase. This patch generates the following fields as part of a group: - horizontal-border-spacing (short) - vertical-border-spacing (short) - line-height (Length) - font (Font) - color (Color) - VisitedLinkColor (Color) - TextAutoSizingMultiplier (float) All fields are generated as storage_only in this patch, but future patches may change that. All these fields are inherited. Inherited fields go through a fast path in ComputedStyle::InheritedDataShared, which is currently handwritten. Hence this patch also generates InheritedDataShared so that it will still work when we change where these fields are stored. Diff of generated files: https://gist.github.com/darrnshn/28f4f79881e6474913f87257fed006a4/revisions BUG=628043 ========== to ========== Generate StyleInheritedData in ComputedStyleBase. This patch generates the following fields as part of a group: - horizontal-border-spacing (short) - vertical-border-spacing (short) - line-height (Length) - font (Font) - color (Color) - VisitedLinkColor (Color) - TextAutoSizingMultiplier (float) All fields are generated as storage_only in this patch, but future patches may change that. Diff of generated files: https://gist.github.com/darrnshn/28f4f79881e6474913f87257fed006a4/revisions BUG=628043 ==========
shend@chromium.org changed reviewers: + meade@chromium.org
Hi Eddy, PTAL (no bots due to dependency)
lgtm
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by shend@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by shend@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org, meade@chromium.org Link to the patchset: https://codereview.chromium.org/2840503002/#ps140001 (title: "Rebase")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 140001, "attempt_start_ts": 1495060890818110,
"parent_rev": "825edf8e5dadff7bce102fdf37d5be5128490c45", "commit_rev":
"48dacf962778b8fb9c0d8b49921d21c9163ba88c"}
Message was sent while issue was closed.
Description was changed from ========== Generate StyleInheritedData in ComputedStyleBase. This patch generates the following fields as part of a group: - horizontal-border-spacing (short) - vertical-border-spacing (short) - line-height (Length) - font (Font) - color (Color) - VisitedLinkColor (Color) - TextAutoSizingMultiplier (float) All fields are generated as storage_only in this patch, but future patches may change that. Diff of generated files: https://gist.github.com/darrnshn/28f4f79881e6474913f87257fed006a4/revisions BUG=628043 ========== to ========== Generate StyleInheritedData in ComputedStyleBase. This patch generates the following fields as part of a group: - horizontal-border-spacing (short) - vertical-border-spacing (short) - line-height (Length) - font (Font) - color (Color) - VisitedLinkColor (Color) - TextAutoSizingMultiplier (float) All fields are generated as storage_only in this patch, but future patches may change that. Diff of generated files: https://gist.github.com/darrnshn/28f4f79881e6474913f87257fed006a4/revisions BUG=628043 Review-Url: https://codereview.chromium.org/2840503002 Cr-Commit-Position: refs/heads/master@{#472598} Committed: https://chromium.googlesource.com/chromium/src/+/48dacf962778b8fb9c0d8b49921d... ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001) as https://chromium.googlesource.com/chromium/src/+/48dacf962778b8fb9c0d8b49921d... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
