Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2886283006: Fix ARC notification crash. (Closed)

Created:
3 years, 7 months ago by Evan Stade
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Fix ARC notification crash. Make ArcCustomNotificationView::SlideHelper operate on the correct layer, i.e. that which is sliding out. This is meant as a temporary hack to address the crash, but the code still needs to be restructured to reduce fragility and improve test coverage. BUG=718965 Review-Url: https://codereview.chromium.org/2863163002 Cr-Original-Commit-Position: refs/heads/master@{#469787} Review-Url: https://codereview.chromium.org/2886283006 . Cr-Commit-Position: refs/branch-heads/3071@{#632} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/8f75642cf2ecc597f87a8a66aa227ec79e947db1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M ui/arc/notification/arc_custom_notification_view.cc View 3 chunks +10 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Evan Stade
3 years, 7 months ago (2017-05-19 15:22:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8f75642cf2ecc597f87a8a66aa227ec79e947db1.

Powered by Google App Engine
This is Rietveld 408576698