Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2863163002:
Fix ARC notification crash. (Closed)
|
Created:
3 years, 7 months ago by Evan Stade Modified:
3 years, 7 months ago CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, yusukes+watch_chromium.org, victorhsieh+watch_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix ARC notification crash.
Make ArcCustomNotificationView::SlideHelper operate on the correct
layer, i.e. that which is sliding out.
This is meant as a temporary hack to address the crash, but the code
still needs to be restructured to reduce fragility and improve test
coverage.
BUG=718965
Review-Url: https://codereview.chromium.org/2863163002
Cr-Commit-Position: refs/heads/master@{#469787}
Committed: https://chromium.googlesource.com/chromium/src/+/99c145d628465ca7c71f46ae39fe875466e3fb5e
Patch Set 1 #
Messages
Total messages: 26 (16 generated)
The CQ bit was checked by estade@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
oshima@google.com changed reviewers: + oshima@google.com
lgtm yep, this fixed the crash. thanks!
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer,_not_ a full super star committer. Committers are members of the group "project-chromium-committers". Note that this has nothing to do with OWNERS files.
oshima@chromium.org changed reviewers: + oshima@chromium.org
#from the correct account lgtm
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
estade@chromium.org changed reviewers: + yoshiki@chromium.org
+yoshiki for owners
Description was changed from ========== Fix ARC notification crash. Make ArcCustomNotificationView::SlideHelper operate on the correct layer, i.e. that which is sliding out. This is meant as a temporary hack to address the crash, but the code still needs to be restructured to reduce fragility and improve test coverage. BUG=718965 ========== to ========== Fix ARC notification crash. Make ArcCustomNotificationView::SlideHelper operate on the correct layer, i.e. that which is sliding out. This is meant as a temporary hack to address the crash, but the code still needs to be restructured to reduce fragility and improve test coverage. BUG=718965 ==========
oshima@chromium.org changed reviewers: + yusukes@chromium.org
lgtm
The CQ bit was checked by oshima@google.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1494024329659290, "parent_rev":
"9380ddb9f45e2f441d4e6c4daffba47ac4e40e46", "commit_rev":
"99c145d628465ca7c71f46ae39fe875466e3fb5e"}
Message was sent while issue was closed.
Description was changed from ========== Fix ARC notification crash. Make ArcCustomNotificationView::SlideHelper operate on the correct layer, i.e. that which is sliding out. This is meant as a temporary hack to address the crash, but the code still needs to be restructured to reduce fragility and improve test coverage. BUG=718965 ========== to ========== Fix ARC notification crash. Make ArcCustomNotificationView::SlideHelper operate on the correct layer, i.e. that which is sliding out. This is meant as a temporary hack to address the crash, but the code still needs to be restructured to reduce fragility and improve test coverage. BUG=718965 Review-Url: https://codereview.chromium.org/2863163002 Cr-Commit-Position: refs/heads/master@{#469787} Committed: https://chromium.googlesource.com/chromium/src/+/99c145d628465ca7c71f46ae39fe... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/99c145d628465ca7c71f46ae39fe... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
