input: Fix running the completion callback for telemetry gesture.

input: Fix running the completion callback for telemetry gesture.

Instead of running the completion callback right after dispatching the
last event, make sure it runs after the last event processing is
complete. For example, if the last event triggers a fling, then it should
be marked complete only after the fling ends.

BUG=722921
Review-Url: https://codereview.chromium.org/2886283004
Cr-Commit-Position: refs/heads/master@{#473235}
Committed: https://chromium.googlesource.com/chromium/src/+/94a4ca46bbe956a4ae033e7e207c584abe1e3645

[sadrul, 2017-05-18 22:08:22]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 22:09:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 22:23:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 22:23:35]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sadrul, 2017-05-19 01:58:53]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 02:00:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 02:21:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 02:21:09]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[sadrul, 2017-05-19 03:08:04]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[sadrul, 2017-05-19 03:08:43]

Patchset #3 (id:20002) has been deleted

[commit-bot: I haz the power, 2017-05-19 03:08:44]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 03:11:53]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[sadrul, 2017-05-19 03:29:52]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-19 03:30:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2017-05-19 04:03:21]

Description was changed from

==========
[wip] input: Fix running the completion callback.

Instead of running the completion callback right after dispatching the
last event, make sure it runs after the last event processing is
complete. For example, if the last event triggers a fling, the it should
be marked complete after the fling ends.

...

BUG=722921
==========

to

==========
[wip] input: Fix running the completion callback.

Instead of running the completion callback right after dispatching the
last event, make sure it runs after the last event processing is
complete. For example, if the last event triggers a fling, then it should
be marked complete only after the fling ends.

BUG=722921
==========

[sadrul, 2017-05-19 04:10:03]

Description was changed from

==========
[wip] input: Fix running the completion callback.

Instead of running the completion callback right after dispatching the
last event, make sure it runs after the last event processing is
complete. For example, if the last event triggers a fling, then it should
be marked complete only after the fling ends.

BUG=722921
==========

to

==========
input: Fix running the completion callback for telemetry gesture.

Instead of running the completion callback right after dispatching the
last event, make sure it runs after the last event processing is
complete. For example, if the last event triggers a fling, then it should
be marked complete only after the fling ends.

BUG=722921
==========

[sadrul, 2017-05-19 04:11:07]

sadrul@chromium.org changed reviewers:
+ dtapuska@chromium.org

[commit-bot: I haz the power, 2017-05-19 05:25:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-19 05:25:59]

Dry run: This issue passed the CQ dry run.

[dtapuska, 2017-05-19 13:20:29]

dtapuska@chromium.org changed reviewers:
+ tdresser@chromium.org

[dtapuska, 2017-05-19 13:20:37]

https://codereview.chromium.org/2886283004/diff/50001/content/browser/rendere...
File content/browser/renderer_host/input/synthetic_gesture_controller.cc
(right):

https://codereview.chromium.org/2886283004/diff/50001/content/browser/rendere...
content/browser/renderer_host/input/synthetic_gesture_controller.cc:73:
RequestBeginFrame();
This will still add an additional frame of latency to the gesture event right?

tdresser@ we don't really care about this too much right? (ie; we don't use the
completion callback for anything other than possibly running the next gesture or
checking the state of things)

[tdresser, 2017-05-19 13:53:32]

https://codereview.chromium.org/2886283004/diff/50001/content/browser/rendere...
File content/browser/renderer_host/input/synthetic_gesture_controller.cc
(right):

https://codereview.chromium.org/2886283004/diff/50001/content/browser/rendere...
content/browser/renderer_host/input/synthetic_gesture_controller.cc:73:
RequestBeginFrame();
On 2017/05/19 13:20:36, dtapuska wrote:
> This will still add an additional frame of latency to the gesture event right?
> 
> tdresser@ we don't really care about this too much right? (ie; we don't use
the
> completion callback for anything other than possibly running the next gesture
or
> checking the state of things)

Yup, this should be fine.

[sadrul, 2017-05-19 16:55:49]

https://codereview.chromium.org/2886283004/diff/50001/content/browser/rendere...
File content/browser/renderer_host/input/synthetic_gesture_controller.cc
(right):

https://codereview.chromium.org/2886283004/diff/50001/content/browser/rendere...
content/browser/renderer_host/input/synthetic_gesture_controller.cc:73:
RequestBeginFrame();
On 2017/05/19 13:20:36, dtapuska wrote:
> This will still add an additional frame of latency to the gesture event right?

This will add at most one frame to the end of the gesture, correct. But it
should not affect the metrics we would normally care about (e.g. queuing
latency, first-update etc.) I believe.

And this also affects the start of the next gesture, but I don't think that
would affect the metrics. It can add one frame to the test duration, but that
should be ok.

> 
> tdresser@ we don't really care about this too much right? (ie; we don't use
the
> completion callback for anything other than possibly running the next gesture
or
> checking the state of things)

[dtapuska, 2017-05-19 17:19:14]

On 2017/05/19 16:55:49, sadrul wrote:
>
https://codereview.chromium.org/2886283004/diff/50001/content/browser/rendere...
> File content/browser/renderer_host/input/synthetic_gesture_controller.cc
> (right):
> 
>
https://codereview.chromium.org/2886283004/diff/50001/content/browser/rendere...
> content/browser/renderer_host/input/synthetic_gesture_controller.cc:73:
> RequestBeginFrame();
> On 2017/05/19 13:20:36, dtapuska wrote:
> > This will still add an additional frame of latency to the gesture event
right?
> 
> This will add at most one frame to the end of the gesture, correct. But it
> should not affect the metrics we would normally care about (e.g. queuing
> latency, first-update etc.) I believe.
> 
> And this also affects the start of the next gesture, but I don't think that
> would affect the metrics. It can add one frame to the test duration, but that
> should be ok.
> 
> > 
> > tdresser@ we don't really care about this too much right? (ie; we don't use
> the
> > completion callback for anything other than possibly running the next
gesture
> or
> > checking the state of things)

lgtm

[sadrul, 2017-05-19 17:34:32]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2017-05-19 17:35:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-19 17:41:07]

CQ is committing da patch.

Bot data: {"patchset_id": 50001, "attempt_start_ts": 1495215272233170,
"parent_rev": "1c0f254c93df392634578b2520fad79b6cf1003f", "commit_rev":
"94a4ca46bbe956a4ae033e7e207c584abe1e3645"}

[commit-bot: I haz the power, 2017-05-19 17:41:18]

Description was changed from

==========
input: Fix running the completion callback for telemetry gesture.

Instead of running the completion callback right after dispatching the
last event, make sure it runs after the last event processing is
complete. For example, if the last event triggers a fling, then it should
be marked complete only after the fling ends.

BUG=722921
==========

to

==========
input: Fix running the completion callback for telemetry gesture.

Instead of running the completion callback right after dispatching the
last event, make sure it runs after the last event processing is
complete. For example, if the last event triggers a fling, then it should
be marked complete only after the fling ends.

BUG=722921

Review-Url: https://codereview.chromium.org/2886283004
Cr-Commit-Position: refs/heads/master@{#473235}
Committed:
https://chromium.googlesource.com/chromium/src/+/94a4ca46bbe956a4ae033e7e207c...
==========

[commit-bot: I haz the power, 2017-05-19 17:41:19]

Committed patchset #3 (id:50001) as
https://chromium.googlesource.com/chromium/src/+/94a4ca46bbe956a4ae033e7e207c...