Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2886283004: input: Fix running the completion callback for telemetry gesture. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_impl.cc
diff --git a/content/browser/renderer_host/render_widget_host_impl.cc b/content/browser/renderer_host/render_widget_host_impl.cc
index cf67ed51b1907f4beb539e2d97585c5ea6c93e77..bd8f764fe2fba3851978fe2919cade995f24e718 100644
--- a/content/browser/renderer_host/render_widget_host_impl.cc
+++ b/content/browser/renderer_host/render_widget_host_impl.cc
@@ -1316,10 +1316,7 @@ void RenderWidgetHostImpl::QueueSyntheticGesture(
if (!synthetic_gesture_controller_ && view_) {
synthetic_gesture_controller_ =
base::MakeUnique<SyntheticGestureController>(
- view_->CreateSyntheticGestureTarget(),
- base::Bind(
- &RenderWidgetHostImpl::RequestBeginFrameForSynthesizedInput,
- base::Unretained(this)));
+ this, view_->CreateSyntheticGestureTarget());
}
if (synthetic_gesture_controller_) {
synthetic_gesture_controller_->QueueSyntheticGesture(
@@ -1864,13 +1861,6 @@ void RenderWidgetHostImpl::OnGpuSwapBuffersCompletedInternal(
latency_tracker_.OnGpuSwapBuffersCompleted(latency_info);
}
-void RenderWidgetHostImpl::RequestBeginFrameForSynthesizedInput(
- base::OnceClosure begin_frame_callback) {
- DCHECK(view_);
- begin_frame_callback_ = std::move(begin_frame_callback);
- view_->OnSetNeedsFlushInput();
-}
-
void RenderWidgetHostImpl::OnRenderProcessGone(int status, int exit_code) {
// RenderFrameHost owns a RenderWidgetHost when it needs one, in which case
// it handles destruction.
@@ -2557,6 +2547,17 @@ void RenderWidgetHostImpl::RequestMojoCompositorFrameSink(
renderer_compositor_frame_sink_ = std::move(client);
}
+void RenderWidgetHostImpl::RequestBeginFrameForSynthesizedInput(
+ base::OnceClosure begin_frame_callback) {
+ DCHECK(view_);
+ begin_frame_callback_ = std::move(begin_frame_callback);
+ view_->OnSetNeedsFlushInput();
+}
+
+bool RenderWidgetHostImpl::HasGestureStopped() {
+ return !input_router_->HasPendingEvents();
+}
+
void RenderWidgetHostImpl::SetNeedsBeginFrame(bool needs_begin_frame) {
OnSetNeedsBeginFrames(needs_begin_frame);
}

Powered by Google App Engine
This is Rietveld 408576698