third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 - Issue 2886233004: Generate diffing functions for generated subgroup InheritedData in ComputedStyle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

Issue 2886233004: Generate diffing functions for generated subgroup InheritedData in ComputedStyle (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

diff --git a/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5 b/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

index e88af56f305fdbf3bc910d4311f48023b23f3147..0c84d05f0b9dd5f64b16de7bf6cdcb81b736a00e 100644

--- a/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

+++ b/third_party/WebKit/Source/core/css/ComputedStyleDiffFunctions.json5

@@ -27,7 +27,7 @@

{

name: "DiffNeedsFullLayoutAndPaintInvalidation",

fields_to_diff: ["padding-top", "padding-left", "padding-right",

- "padding-bottom"],

+ "padding-bottom", "line-height", "font", "-webkit-border-horizontal-spacing", "-webkit-border-vertical-spacing"],

shend 2017/05/18 22:17:51 weird line wrapping from rietveld :/

nainar 2017/05/19 00:00:38 I ran git cl format over this and it stayed the sa

shend 2017/05/19 00:09:18 oh it's not the code itself, it's way it's present

nainar 2017/05/19 00:15:02 The side by side diff is a bit weird ok - I had it

alancutter (OOO until 2018) 2017/05/19 01:16:58 I don't think git cl format does Python.

methods_to_diff: [

{

method: "BorderLeftWidth()",

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('J')